Remove kind/resource type mentions from metadata.name in resources

[amadhusu]

The issue resolved by this Pull Request:

Resolves RHOAIENG-1680

Description of your changes:

This PR removes kind/resource type mentions from metadata.name in resources

Testing instructions

Just normal Sanity checks

Checklist

• The commits are squashed in a cohesive manner and have meaningful messages.
• Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
• The developer has manually tested the changes and verified that the changes work

[dsp-developers]

A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-557
An OCP cluster where you are logged in as cluster admin is required.

To use this image run the following:

cd $(mktemp -d)
git clone git@github.com:opendatahub-io/data-science-pipelines-operator.git
cd data-science-pipelines-operator/
git fetch origin pull/557/head
git checkout -b pullrequest 11d6114a7fa26b92f480e3d4536b90e25cbcf1da
make deploy IMG="quay.io/opendatahub/data-science-pipelines-operator:pr-557"

More instructions here on how to deploy and test a Data Science Pipelines Application.

[amadhusu]

/test

[gregsheremeta]

Aren't there RoleBindings that would need to be changed as well? (edit: or in this case, ClusterRoleBindings...)

[amadhusu]

Aren't there RoleBindings that would need to be changed as well? (edit: or in this case, ClusterRoleBindings...)

@gregsheremeta I couldn't find any ClusterRoleBindings in this case. Do you have a reference point if any?

[gregsheremeta]

Nope, I'm not very familiar with them.

@gmfrasca do you know if there are ClusterRoleBindings somewhere that would also need to be changed?

[DharmitD]

Nope, I'm not very familiar with them.

@gmfrasca do you know if there are ClusterRoleBindings somewhere that would also need to be changed?

Looks like the CRBs were deleted by this commit on the dspv2 branch: 85d2e0f

So yeah they don't exist and you wouldn't need to update them.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign gregsheremeta for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[dsp-developers]

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-557

[DharmitD]

/lgtm