Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: further simplify v2 simple dspa example. #514

Merged
merged 1 commit into from
Dec 15, 2023

Conversation

HumairAK
Copy link
Contributor

@HumairAK HumairAK commented Dec 15, 2023

Testing instructions

make deploy argodeploy
oc new-project kubeflow
make deploy
oc -n kubeflow apply -f config/samples/dspa_simple_v2.yaml
# run the iris pipeline, it should complete successfully

Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
@amadhusu
Copy link
Contributor

/lgtm

Copy link
Contributor

openshift-ci bot commented Dec 15, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: amadhusu
Once this PR has been reviewed and has the lgtm label, please ask for approval from humairak. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@HumairAK HumairAK merged commit a79e48f into opendatahub-io:dspv2 Dec 15, 2023
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants