Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workaround to fix artifact passing #513

Merged
merged 2 commits into from
Dec 14, 2023

Conversation

HumairAK
Copy link
Contributor

Work around to make storage artifact passing work until #494 is resolved.

Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
@HumairAK HumairAK changed the title Dspv2 secrets Add workaround to fix artifact passing Dec 13, 2023
@dsp-developers
Copy link
Contributor

A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-513
An OCP cluster where you are logged in as cluster admin is required.

To use this image run the following:

cd $(mktemp -d)
git clone git@github.com:opendatahub-io/data-science-pipelines-operator.git
cd data-science-pipelines-operator/
git fetch origin pull/513/head
git checkout -b pullrequest 420719e8ca6fc05f5c63bb9ef6d00e542df2a124
make deploy IMG="quay.io/opendatahub/data-science-pipelines-operator:pr-513"

More instructions here on how to deploy and test a Data Science Pipelines Application.

Copy link
Member

@gmfrasca gmfrasca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Deployed both v1 and v2 DSPAs and verified sample workflows run successfully. Verified artifacts were properly saved in Object Storage and respective Secrets were used for access (ds-pipelines-s3-{{.Name}} for v1 and mlpipeline-minio-artifact for v2)

@amadhusu
Copy link
Contributor

/lgtm

Verified by deploying both v1 and v2 DSPAs similar to what @gmfrasca did. Verified the artifacts were perfectly saved and the respective secrets were used for each version.

Copy link
Contributor

openshift-ci bot commented Dec 14, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: amadhusu
Once this PR has been reviewed and has the lgtm label, please ask for approval from gmfrasca. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@HumairAK HumairAK merged commit 6127c4d into opendatahub-io:dspv2 Dec 14, 2023
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants