Address linting and deprecated ioutil pkg. #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Humair Khan <humair88@hotmail.com>
Signed-off-by: Humair Khan <humair88@hotmail.com>
|
one sec, the pull yaml is not supposed to be on here, that change should only go downstream |
HumairAK
referenced
this pull request
in HumairAK/data-science-pipelines-operator
Mar 24, 2023
Remove unnecessary comment in pull config.
HumairAK
added a commit
to dsp-developers/data-science-pipelines-operator
that referenced
this pull request
Aug 22, 2023
…-doc-generate-1.3 Update DSP version compatibility doc.
HumairAK
added a commit
to dsp-developers/data-science-pipelines-operator
that referenced
this pull request
Aug 22, 2023
…-doc-generate-1.3 Update DSP version compatibility doc.
HumairAK
added a commit
to dsp-developers/data-science-pipelines-operator
that referenced
this pull request
Aug 22, 2023
…-doc-generate-1.3 Update DSP version compatibility doc.
HumairAK
added a commit
to dsp-developers/data-science-pipelines-operator
that referenced
this pull request
Aug 22, 2023
…-doc-generate-1.3 Update DSP version compatibility doc.
dsp-developers
pushed a commit
to dsp-developers/data-science-pipelines-operator
that referenced
this pull request
Aug 22, 2023
…-doc-generate-1.3 Update DSP version compatibility doc.
dsp-developers
pushed a commit
to dsp-developers/data-science-pipelines-operator
that referenced
this pull request
Aug 22, 2023
…-doc-generate-1.3 Update DSP version compatibility doc.
dsp-developers
pushed a commit
to dsp-developers/data-science-pipelines-operator
that referenced
this pull request
Aug 22, 2023
…-doc-generate-1.3 Update DSP version compatibility doc.
dsp-developers
pushed a commit
to dsp-developers/data-science-pipelines-operator
that referenced
this pull request
Aug 22, 2023
…-doc-generate-1.3 Update DSP version compatibility doc.
dsp-developers
pushed a commit
to dsp-developers/data-science-pipelines-operator
that referenced
this pull request
Aug 22, 2023
…-doc-generate-1.3 Update DSP version compatibility doc.
dsp-developers
pushed a commit
to dsp-developers/data-science-pipelines-operator
that referenced
this pull request
Aug 22, 2023
…-doc-generate-1.3 Update DSP version compatibility doc.
dsp-developers
pushed a commit
to dsp-developers/data-science-pipelines-operator
that referenced
this pull request
Aug 22, 2023
…-doc-generate-1.3 Update DSP version compatibility doc.
dsp-developers
pushed a commit
to dsp-developers/data-science-pipelines-operator
that referenced
this pull request
Aug 22, 2023
…-doc-generate-1.3 Update DSP version compatibility doc.
HumairAK
added a commit
to dsp-developers/data-science-pipelines-operator
that referenced
this pull request
Aug 22, 2023
…-doc-generate-1.3 Update DSP version compatibility doc.
dsp-developers
pushed a commit
to dsp-developers/data-science-pipelines-operator
that referenced
this pull request
Aug 22, 2023
…-doc-generate-1.3 Update DSP version compatibility doc.
dsp-developers
pushed a commit
to dsp-developers/data-science-pipelines-operator
that referenced
this pull request
Aug 22, 2023
…-doc-generate-1.3 Update DSP version compatibility doc.
dsp-developers
pushed a commit
to dsp-developers/data-science-pipelines-operator
that referenced
this pull request
Aug 22, 2023
…-doc-generate-1.3 Update DSP version compatibility doc.
dsp-developers
pushed a commit
to dsp-developers/data-science-pipelines-operator
that referenced
this pull request
Aug 22, 2023
…-doc-generate-1.3 Update DSP version compatibility doc.
dsp-developers
pushed a commit
to dsp-developers/data-science-pipelines-operator
that referenced
this pull request
Aug 22, 2023
…-doc-generate-1.3 Update DSP version compatibility doc.
dsp-developers
pushed a commit
to dsp-developers/data-science-pipelines-operator
that referenced
this pull request
Aug 22, 2023
…-doc-generate-1.3 Update DSP version compatibility doc.
dsp-developers
pushed a commit
to dsp-developers/data-science-pipelines-operator
that referenced
this pull request
Aug 22, 2023
…-doc-generate-1.3 Update DSP version compatibility doc.
dsp-developers
pushed a commit
to dsp-developers/data-science-pipelines-operator
that referenced
this pull request
Aug 22, 2023
…-doc-generate-1.3 Update DSP version compatibility doc.
dsp-developers
pushed a commit
to dsp-developers/data-science-pipelines-operator
that referenced
this pull request
Aug 22, 2023
…-doc-generate-1.3 Update DSP version compatibility doc.
dsp-developers
pushed a commit
to dsp-developers/data-science-pipelines-operator
that referenced
this pull request
Aug 22, 2023
…-doc-generate-1.3 Update DSP version compatibility doc.
dsp-developers
pushed a commit
to dsp-developers/data-science-pipelines-operator
that referenced
this pull request
Aug 22, 2023
…-doc-generate-1.3 Update DSP version compatibility doc.
dsp-developers
pushed a commit
to dsp-developers/data-science-pipelines-operator
that referenced
this pull request
Aug 22, 2023
…-doc-generate-1.3 Update DSP version compatibility doc.
dsp-developers
pushed a commit
to dsp-developers/data-science-pipelines-operator
that referenced
this pull request
Aug 22, 2023
…-doc-generate-1.3 Update DSP version compatibility doc.
HumairAK
added a commit
to dsp-developers/data-science-pipelines-operator
that referenced
this pull request
Aug 22, 2023
…-doc-generate-1.3 Update DSP version compatibility doc.
dsp-developers
pushed a commit
to dsp-developers/data-science-pipelines-operator
that referenced
this pull request
Aug 22, 2023
…-doc-generate-1.3 Update DSP version compatibility doc.
dsp-developers
pushed a commit
to dsp-developers/data-science-pipelines-operator
that referenced
this pull request
Aug 22, 2023
…-doc-generate-1.3 Update DSP version compatibility doc.
dsp-developers
pushed a commit
to dsp-developers/data-science-pipelines-operator
that referenced
this pull request
Aug 22, 2023
…-doc-generate-1.3 Update DSP version compatibility doc.
dsp-developers
pushed a commit
to dsp-developers/data-science-pipelines-operator
that referenced
this pull request
Aug 23, 2023
…-doc-generate-1.3 Update DSP version compatibility doc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the failure here
Donnu why it wasn't caught in upstream repo, but the error was accurate. We might need to make sure the yaml lint config is being picked up in the github action.
There's also a commit that addresses deprecated package for ioutil. Again not sure why this wasn't picked up upstream. My suspicion is both the yamllint and golanglint configs are not being included in the github action.