Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flag to APIServer service's oauth port #491

Merged

Conversation

cam-garrison
Copy link
Contributor

The issue resolved by this Pull Request:

Resolves #490

Description of your changes:

This small PR wraps the Oauth port in the APIServer's Service object behind the .APIServer.EnableRoute flag so that if a DSPA is created with spec.apiServer.enableOauth=false, this port will not exist in the service.

Testing instructions

Tested with IMG=quay.io/cgarriso/data-science-pipelines-operator:service-oauth

Deployed DSPO, created a sample DSPA with

spec:
  apiServer:
    enableOauth: false

and ensured that port:

    - name: oauth
      port: 8443
      protocol: TCP
      targetPort: oauth

is not present in the service.

Similarly, created DSPA with enableOauth: true and ensured that the port was in the service.

Checklist

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@dsp-developers
Copy link
Contributor

A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-491
An OCP cluster where you are logged in as cluster admin is required.

To use this image run the following:

cd $(mktemp -d)
git clone git@github.com:opendatahub-io/data-science-pipelines-operator.git
cd data-science-pipelines-operator/
git fetch origin pull/491/head
git checkout -b pullrequest dca773543200c97677d416dddfb594d4c29bba0d
make deploy IMG="quay.io/opendatahub/data-science-pipelines-operator:pr-491"

More instructions here on how to deploy and test a Data Science Pipelines Application.

@amadhusu
Copy link
Contributor

amadhusu commented Dec 1, 2023

/lgtm

@amadhusu
Copy link
Contributor

amadhusu commented Dec 1, 2023

/approve

@HumairAK
Copy link
Contributor

HumairAK commented Dec 7, 2023

/lgtm
/approve

Thanks!!

Copy link
Contributor

openshift-ci bot commented Dec 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amadhusu, HumairAK

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Dec 7, 2023
@openshift-merge-bot openshift-merge-bot bot merged commit f6dbcdc into opendatahub-io:main Dec 7, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: APIServer with enableOauth=False still has oauth port in APIServer service
4 participants