Add flag to APIServer service's oauth port #491
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue resolved by this Pull Request:
Resolves #490
Description of your changes:
This small PR wraps the Oauth port in the APIServer's Service object behind the
.APIServer.EnableRoute
flag so that if a DSPA is created withspec.apiServer.enableOauth=false
, this port will not exist in the service.Testing instructions
Tested with
IMG=quay.io/cgarriso/data-science-pipelines-operator:service-oauth
Deployed DSPO, created a sample DSPA with
and ensured that port:
is not present in the service.
Similarly, created DSPA with
enableOauth: true
and ensured that the port was in the service.Checklist