Improve Container Env Comparison in FuncTests #463
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes:
Add context to container env divergence test failures, Rather than give a vague message that is difficult to triage fix.
Testing instructions
Add an env var name+value entry in one of the deployment.yamls used for verification in functional tests, such as
controllers/testdata/declarative/case_0/expected/created/apiserver_deployment.yaml
. Verify that the error message now shows the number of env vars both expected and experienced, as well as a detailed report of which one is missing.Repeat but this time remove one of the expected env vars instead.
Checklist