Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Container Env Comparison in FuncTests #463

Merged

Conversation

gmfrasca
Copy link
Member

Description of your changes:

Add context to container env divergence test failures, Rather than give a vague message that is difficult to triage fix.

Testing instructions

Add an env var name+value entry in one of the deployment.yamls used for verification in functional tests, such as controllers/testdata/declarative/case_0/expected/created/apiserver_deployment.yaml. Verify that the error message now shows the number of env vars both expected and experienced, as well as a detailed report of which one is missing.

Repeat but this time remove one of the expected env vars instead.

Checklist

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@dsp-developers
Copy link
Contributor

A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-463
An OCP cluster where you are logged in as cluster admin is required.

To use this image run the following:

cd $(mktemp -d)
git clone git@github.com:opendatahub-io/data-science-pipelines-operator.git
cd data-science-pipelines-operator/
git fetch origin pull/463/head
git checkout -b pullrequest 797077f748ba9b8119bda3d1c49714f2c2a03904
make deploy IMG="quay.io/opendatahub/data-science-pipelines-operator:pr-463"

More instructions here on how to deploy and test a Data Science Pipelines Application.

Copy link
Member

@DharmitD DharmitD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/Approve

Copy link
Contributor

openshift-ci bot commented Nov 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DharmitD

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit b8e5b06 into opendatahub-io:main Nov 15, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants