Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 1.4.1 to stable #452

Merged
merged 37 commits into from
Nov 9, 2023
Merged

Add 1.4.1 to stable #452

merged 37 commits into from
Nov 9, 2023

Conversation

HumairAK
Copy link
Contributor

@HumairAK HumairAK commented Nov 9, 2023

From v1.3.2 to v1.4.1
Matches diff: v1.3.2...v1.4.1

HumairAK and others added 30 commits August 25, 2023 10:50
Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
Correct org mention in release notes links.
Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
Hardcode obj store info in artifact script.
Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
Correct artifact endpoints/bucket for test cases.
- Hook is no longer used with addition of new test labels
…tests

Improve GitHub Testing Actions names
Some tasks and especially root task in pipeline uses:
quay.io/hukhan/python:alpine3.6
see:
https://github.com/opendatahub-io/data-science-pipelines-operator/blob/b34fbb8402efd3f2092c7931f683d5b906809961/docs/example_pipelines/condition.yaml#L84

other steps used (dockerhub):
image: python:alpine3.6
see:
https://github.com/opendatahub-io/data-science-pipelines-operator/blob/b34fbb8402efd3f2092c7931f683d5b906809961/docs/example_pipelines/condition.yaml#L455

so aligns images to root task image

code review: using registry.access.redhat.com/ubi8/python-38

in all places.

Note: registry.access.redhat.com supports unauthenticated access,
good from community pov.

update kfp dsl for required changes

code review: update to ubi8/python-39
…-pipelineimagealignment

align example pipeline yaml images
Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
Add pattern requirement for mariadb db/user name.
Currently we have the default sincle thread reconcile loop, which is not
very scalable and results in blocking reconciles during db/storage
healthchecks. It also drastically reduces the time to deploy increasing
number of DSPAs. This change will increase concurrent reconciles to 10
to resolve some of these scalability issues.

Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
Add timeout to db/storage health checks, increase reconcile concurrency
Update kfdef to correctly replace versions
Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
HumairAK and others added 7 commits September 15, 2023 14:50
Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
This change will allow users to specify a configmap that contains a ca
bundle. This ca bundle is injected into the api server pod.
Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
Copy link
Contributor

openshift-ci bot commented Nov 9, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from humairak. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@HumairAK HumairAK merged commit 4402e56 into opendatahub-io:stable Nov 9, 2023
1 check was pending
@dsp-developers
Copy link
Contributor

A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-452
An OCP cluster where you are logged in as cluster admin is required.

To use this image run the following:

cd $(mktemp -d)
git clone git@github.com:opendatahub-io/data-science-pipelines-operator.git
cd data-science-pipelines-operator/
git fetch origin pull/452/head
git checkout -b pullrequest d6632ba207c33c9e21e52c43a065aece15218e62
make deploy IMG="quay.io/opendatahub/data-science-pipelines-operator:pr-452"

More instructions here on how to deploy and test a Data Science Pipelines Application.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants