-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parameterized HealthCheck Timeouts #433
Conversation
A new image has been built to help with testing out this PR: To use this image run the following: cd $(mktemp -d)
git clone git@github.com:opendatahub-io/data-science-pipelines-operator.git
cd data-science-pipelines-operator/
git fetch origin pull/433/head
git checkout -b pullrequest d8289bcddd83160cbbd3f00a2b227bac8a7d0f3f
make deploy IMG="quay.io/opendatahub/data-science-pipelines-operator:pr-433" More instructions here on how to deploy and test a Data Science Pipelines Application. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hate to propose something drastically different, but I feel like these should be configurable fields in the DSPA CRD (ie spec.database.healthchecktimeout
and spec.objectStore.healthCheckTimeout
) rather than a CLI parameter, perhaps even introducing the concept of a HealthCheck item that has a disabled
(previously implemented as Spec.Database.DisableHealthCheck
) and new timeout
field, which this pr would implement
Change to PR detected. A new PR build was completed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needs rebased but otherwise /lgtm
Signed-off-by: Helber Belmiro <helber.belmiro@gmail.com>
Change to PR detected. A new PR build was completed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/Approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: DharmitD, gmfrasca, hbelmiro The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The issue resolved by this Pull Request:
Resolves #328
Description of your changes:
Parameterized
DBConnectionTimeout
andObjStoreConnectionTimeout
.MaxConcurrentReconciles
was already parameterized.Testing instructions
Set the variables
DB_CONNECTION_TIMEOUT
andOBJ_STORE_CONNECTION_TIMEOUT
, run DSPO, create a DSPA, and ensure the DSPA deploys correctly.Checklist