Add required fields to e2e cr. #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Humair Khan <humair88@hotmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
rimolive
requested changes
Mar 10, 2023
DharmitD
reviewed
Mar 10, 2023
| @@ -56,7 +56,7 @@ function create_pipeline() { | |||
|
|
|||
| ROUTE=$(oc get route ds-pipeline-ui-sample --template={{.spec.host}}) | |||
| SA_TOKEN=$(oc create token ds-pipeline-ui-sample) | |||
| PIPELINE_ID=$(curl -s -k -H "Authorization: Bearer ${SA_TOKEN}" -F "uploadfile=@${RESOURCEDIR}/test-pipeline-run.yaml" https://${ROUTE}/apis/v1beta1/pipelines/upload | jq -r .id) | |||
There was a problem hiding this comment.
Ideally should work even without the quotes
https://github.com/opendatahub-io/data-science-pipelines/blob/master/tests/basictests/ds-pipelines.sh#L40 for instance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
E2E tests Cr update, also a quick syntax update to curl call.
How Has This Been Tested?
Can't test locally, will need to merge and test via ci
Merge criteria: