Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Nightly Build/Test GHAction stub #415

Merged
merged 1 commit into from
Oct 20, 2023

Conversation

gmfrasca
Copy link
Member

The issue resolved by this Pull Request:

Resolves #372

Description of your changes:

Add a simple GH Workflow that runs Nightly. To start we simply run a sample build and execute unit and functional tests.

Testing instructions

Verify logs from https://github.com/gmfrasca/data-science-pipelines-operator/actions/workflows/nightly_tests.yml looks good. Depending on permissions you may be able to run it manually yourself as well (this is the reason for workflow_dispatch: {} in the triggers)

Checklist

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Copy link
Member

@DharmitD DharmitD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

@rimolive rimolive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rimolive

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot merged commit 913f6e0 into opendatahub-io:main Oct 20, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create stub nightly GH action run (will be used for nightly tests)
3 participants