Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DSPv2 NetworkPolicy changes #413

Merged
merged 1 commit into from
Oct 20, 2023

Conversation

rimolive
Copy link
Contributor

Add NetworkPolicy for kfp-driver and TaskRuns to allow access to AP Server

The issue resolved by this Pull Request:

Resolves #369

Description of your changes:

kfp-driver is located under openshift-pipelines namespace, and it needs access to DSP API Server. On the DSP namespace, TaskRun pods also need access to API Server.

The NetworkPolicy changes are made to satisfy the new v2 requirements

Testing instructions

  • Deploy DSPOv2
  • Create a DSPA CR under a specific namespace
  • Use the iris-pipeline example to create and run a pipeline
  • The pipeline run should finish successfuly

Checklist

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@dsp-developers
Copy link
Contributor

A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-413
An OCP cluster where you are logged in as cluster admin is required.

To use this image run the following:

cd $(mktemp -d)
git clone git@github.com:opendatahub-io/data-science-pipelines-operator.git
cd data-science-pipelines-operator/
git fetch origin pull/413/head
git checkout -b pullrequest 1416f286a50937a1e08e2b39bd0639231385bdd7
make deploy IMG="quay.io/opendatahub/data-science-pipelines-operator:pr-413"

More instructions here on how to deploy and test a Data Science Pipelines Application.

Copy link
Member

@DharmitD DharmitD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@HumairAK
Copy link
Contributor

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HumairAK

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot merged commit 327d3ab into opendatahub-io:dspv2 Oct 20, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants