-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Webhook RBAC and APIServer EnvVar updates #409
Conversation
- Allow capability to delete mutating and validating webhookconfigurations - Allow capability to CRUD finalizers on openshift-pipelines namespace
A new image has been built to help with testing out this PR: To use this image run the following: cd $(mktemp -d)
git clone git@github.com:opendatahub-io/data-science-pipelines-operator.git
cd data-science-pipelines-operator/
git fetch origin pull/409/head
git checkout -b pullrequest 945411241b7e325c9bd17762ec8ce7e871d0a404
make deploy IMG="quay.io/opendatahub/data-science-pipelines-operator:pr-409" More instructions here on how to deploy and test a Data Science Pipelines Application. |
9454112
to
6e1bc40
Compare
Change to PR detected. A new PR build was completed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Part of #369
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/Approve
Part of #379
controllers/testdata/declarative/case_0/expected/created/apiserver_deployment.yaml
Outdated
Show resolved
Hide resolved
/hold |
6e1bc40
to
2e17ad4
Compare
/unhold |
controllers/testdata/declarative/case_5/expected/created/apiserver_deployment.yaml
Show resolved
Hide resolved
Change to PR detected. A new PR build was completed. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: DharmitD, HumairAK The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Resolves #379
Description of your changes:
Testing instructions
Deploy v2 infra (
make v2deploy
), ensure webhooks do not have Permission Denied errorsDeploy DSPA with MLMD, ensure METADATA_GRPC_SERVICE_SERVICE_HOST and METADATA_GRPC_SERVICE_SERVICE_PORT are defined in the APIServer Deployment Environment Vars
Checklist