-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebase from dspv1 main, Add v2undeploy command to Makefile #401
Conversation
Fix typo in README
Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
Add gh workflow to auto add issues to proj.
Improved logs for deep comparisons in equalities.go
Added descriptive comments to DSPASpec
This adds a basic high level overview of what DSP is to the README
Add DSP overview to readme
Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
…_1.5 Update 1.5 compatibility doc.
…info` as default. Signed-off-by: Helber Belmiro <helber.belmiro@gmail.com>
…ty-doc-generate-1.5 Update DSP version compatibility doc.
Added argument to configure log levels for the operator and defined `…
- New image built to use go1.19
- io/ioutil is Deprecated as of Go 1.19, os now provides same functionality
Upgrade to Go 1.19
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
- Some components have conditions (only deploy if XYZ option set), so seperate these specific manifests from rest of the 'default ones for that component
c275a9c
to
5594994
Compare
Change to PR detected. A new PR build was completed. |
1 similar comment
Change to PR detected. A new PR build was completed. |
- Fix duplicate key in v2/kustomization.yaml - Fix end-of-file newlines
0f5afa6
to
9700595
Compare
Change to PR detected. A new PR build was completed. |
I reviewed the makefile change and just skimmed everything else /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gregsheremeta The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description of your changes:
Rebase from
main
(pull in CI fixes)Adds v2undeploy command to Makefile
Testing instructions
make v2deploy
, thenmake v2undeploy
and ensure all dsp-v2 objects are cleaned upChecklist