-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integration Test suite + kind workflow to add them to ci #384
Conversation
A new image has been built to help with testing out this PR: To use this image run the following: cd $(mktemp -d)
git clone git@github.com:opendatahub-io/data-science-pipelines-operator.git
cd data-science-pipelines-operator/
git fetch origin pull/384/head
git checkout -b pullrequest bb197177276a8e4209a9643f436407cfd88598ca
make deploy IMG="quay.io/opendatahub/data-science-pipelines-operator:pr-384" More instructions here on how to deploy and test a Data Science Pipelines Application. |
Change to PR detected. A new PR build was completed. |
Change to PR detected. A new PR build was completed. |
Systest nomenclature is incorrect, everything will need to be renamed to integration. |
Change to PR detected. A new PR build was completed. |
Change to PR detected. A new PR build was completed. |
Change to PR detected. A new PR build was completed. |
Change to PR detected. A new PR build was completed. |
Change to PR detected. A new PR build was completed. |
cbb5048
to
468a4b2
Compare
Change to PR detected. A new PR build was completed. |
Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
The these tests were incorrectly named, the correct nomenclature as per dsp testing adr is integration tests. Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
Use constant variables. Remove unused variables in kind tests. Consistent yaml formatting. Clarify readme. Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
Change to PR detected. A new PR build was completed. |
1 similar comment
Change to PR detected. A new PR build was completed. |
Change to PR detected. A new PR build was completed. |
Change to PR detected. A new PR build was completed. |
/unhold |
Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
Change to PR detected. A new PR build was completed. |
/lgtm |
The issue resolved by this Pull Request:
Resolves #285
Description of your changes:
Test suite is introduced as its own isolated pagic.
It is platform agnostic, and can be ran against a dev cluster (see readme) or via command line, or kind cluster for pr testing (see attached workflow).
Test suite uses ginkgo/gomega. It uses client-go to verify changes in cluster, and basic rest calls to verify changes to the api server.
There are some basic tests included:
These tests should give an easy stepping stone for more advanced testing/extensions.
Testing instructions
See readme in the pr
Checklist