Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH action for automated PRs to odh-manifests #208

Merged
merged 1 commit into from
Jul 26, 2023
Merged

GH action for automated PRs to odh-manifests #208

merged 1 commit into from
Jul 26, 2023

Conversation

DharmitD
Copy link
Member

@DharmitD DharmitD commented Jul 18, 2023

Resolves #178

Description

A github action that, when provided a tag version input will open a PR in odh-manifest that will sync the data-science-pipelines-operator manifests that reside here:
https://github.com/opendatahub-io/data-science-pipelines-operator/tree/main/config
with target dest here:
https://github.com/opendatahub-io/odh-manifests/tree/master/data-science-pipelines-operator

How Has This Been Tested?

Added the GH action on my fork of the DSPO repository.
Find the successful GH action workflow runs on my fork here: https://github.com/DharmitD/data-science-pipelines-operator/actions/workflows/odh-manifests-sync.yml
Find PR to odh-manifests repository created via the workflow here: DharmitD/odh-manifests#4

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@DharmitD DharmitD changed the title WIP: GH action for automated PRs to odh-manifests GH action for automated PRs to odh-manifests Jul 18, 2023
@DharmitD
Copy link
Member Author

/hold

Holding merge until we added a Personal Access Token as a secret to the DSPO repository.

@DharmitD
Copy link
Member Author

/unhold

.github/workflows/odh-manifests-PR-sync.yml Outdated Show resolved Hide resolved
.github/workflows/odh-manifests-PR-sync.yml Outdated Show resolved Hide resolved
@HumairAK
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot removed the lgtm label Jul 26, 2023
@HumairAK
Copy link
Contributor

/lgtm
/approve

@HumairAK
Copy link
Contributor

/hold

Copy link
Member

@anishasthana anishasthana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold

@HumairAK
Copy link
Contributor

/unhold

@HumairAK
Copy link
Contributor

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 26, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anishasthana, HumairAK

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [HumairAK,anishasthana]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 8fe21e8 into opendatahub-io:main Jul 26, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automated PRs to odh-manifest
5 participants