Improve custom artifact script handling. #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: HumairAK The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
HumairAK
force-pushed
the
odh_issue_19
branch
from
fa095bc
to
9b80d25
Compare
Since the recently updated cr spec has not had its respective code changes to make it go into effect, we should keep the old cr spec present as before. In this change the proposed cr spec is named as such. Signed-off-by: Humair Khan <humair88@hotmail.com>
This change will make it so api server will fail to deploy if a custom artifact script provided by the user does not exist. Furthermore, it will also ensure that the default artifact script follows naming conventions that are consistent with the rest of the namespace scoped resources. Tests are addded to accomodate this change. Signed-off-by: Humair Khan <humair88@hotmail.com>
HumairAK
force-pushed
the
odh_issue_19
branch
from
9b80d25
to
24f973b
Compare
|
This pr did not have the code changes to go along with it. This was resulting in a conflict with this pr which is applying a change to the original cr spec. I've added another commit that keeps the old cr spec as the standard until another follow up pr to #8 with the code changes takes effect. The proposed cr spec is also kept but the file is named as such. |
dsp-developers
pushed a commit
to dsp-developers/data-science-pipelines-operator
that referenced
this pull request
Aug 22, 2023
…umairAK-patch-1 Update README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will make it so api server will fail to deploy if a custom artifact script provided by the user does not exist. Furthermore, it will also ensure that the default artifact script follows naming conventions that are consistent with the rest of the namespace scoped resources. Tests are addded to accomodate this change.
Description
Resolve #19
How Has This Been Tested?
Via unit tests, and live ocp cluster.
Merge criteria: