-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Infer the "secure" field in dspa based on scheme #196
Conversation
So now that secure is removed here ... how do you handle setting secure to either true or false in i.e. odh dashboard? |
c5e820f
to
27325ee
Compare
@amadhusu can you squash your commits |
6029935
to
9d7dea7
Compare
Signed-off-by: Achyut Madhusudan <amadhusu@redhat.com>
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: HumairAK The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Resolves #157
Description
Infer the "secure" field in dspa based on the scheme which
How Has This Been Tested?
Manually tested this on Openshift Cluster to ensure removing this field doesn't hinder anything.
Merge criteria: