Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix statuses #124

Merged
merged 2 commits into from
May 18, 2023
Merged

Fix statuses #124

merged 2 commits into from
May 18, 2023

Conversation

HumairAK
Copy link
Contributor

Description

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@HumairAK HumairAK requested a review from gmfrasca May 18, 2023 15:52
@openshift-ci openshift-ci bot requested review from DharmitD and rimolive May 18, 2023 15:52
@HumairAK HumairAK requested review from rimolive and removed request for rimolive and DharmitD May 18, 2023 15:52
@HumairAK
Add dspa namespace to publish metric logs.
f0d4527 
Signed-off-by: Humair Khan <humair88@hotmail.com>
@HumairAK
Correct status for scaled down deployments.
4c7dcac 
This change ensures that when persistent agent, scheduled workflow, and
api server deployments are scaled down, the owning DSPA displays their
status "Available" as "false".

Signed-off-by: Humair Khan <humair88@hotmail.com>
@HumairAK HumairAK requested a review from gmfrasca May 18, 2023 16:54
gmfrasca
gmfrasca reviewed May 18, 2023
View reviewed changes
Copy link
Member

@gmfrasca gmfrasca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label May 18, 2023
DharmitD
DharmitD approved these changes May 18, 2023
View reviewed changes
Copy link
Member

@DharmitD DharmitD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/Approve

@rimolive
Copy link
Contributor

/lgtm
/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DharmitD, rimolive

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit c4742f4 into opendatahub-io:main May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmfrasca gmfrasca gmfrasca left review comments

@DharmitD DharmitD DharmitD approved these changes

@rimolive rimolive Awaiting requested review from rimolive

Assignees

@rimolive rimolive

@gmfrasca gmfrasca

@DharmitD DharmitD

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
5 participants
@HumairAK @rimolive @gmfrasca @DharmitD @openshift-merge-robot