Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ViewerCRD deployment #105

Merged
merged 1 commit into from
May 3, 2023
Merged

Remove ViewerCRD deployment #105

merged 1 commit into from
May 3, 2023

Conversation

rimolive
Copy link
Contributor

@rimolive rimolive commented Apr 25, 2023

Description

Remove viewerCRD from Operator code. This is part of the work to make DSPA simpler, deploying only the components that will be part of the Data Science Pipelines release.

How Has This Been Tested?

  • make run
  • Deploy Any DSPA CR
  • Check if the messages to deploy viewerCRD are gone

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@rimolive
Copy link
Contributor Author

/hold

@rimolive rimolive changed the title [Draft] Remove ViewerCRD deployment Remove ViewerCRD deployment Apr 27, 2023
@rimolive
Copy link
Contributor Author

/unhold

Copy link
Member

@DharmitD DharmitD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Skimmed through changes and checked e2e logs.

@HumairAK
Copy link
Contributor

HumairAK commented May 3, 2023

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 3, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HumairAK

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label May 3, 2023
@HumairAK
Copy link
Contributor

HumairAK commented May 3, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm label May 3, 2023
@openshift-merge-robot openshift-merge-robot merged commit 4c16188 into opendatahub-io:main May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants