Skip to content

Commit

Permalink
Rename systest to integartion tests.
Browse files Browse the repository at this point in the history
The these tests were incorrectly named, the correct nomenclature as per
dsp testing adr is integration tests.

Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
  • Loading branch information
HumairAK committed Oct 24, 2023
1 parent 8a589c5 commit cdd4e81
Show file tree
Hide file tree
Showing 7 changed files with 18 additions and 18 deletions.
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: KinD DSPO/DSP system tests
name: KinD DSPO/DSP Integration Tests

on:
workflow_dispatch:
Expand Down Expand Up @@ -26,7 +26,7 @@ env:
DSPA_NAMESPACE: test-dspa
DSPA_NAME: test-dspa
DSPA_DEPLOY_WAIT_TIMEOUT: 300
SYSTEM_TESTS_DIR: ${{ github.workspace }}/tests
INTEGRATION_TESTS_DIR: ${{ github.workspace }}/tests
jobs:
dspo-tests:
runs-on: ubuntu-20.04
Expand Down Expand Up @@ -78,12 +78,12 @@ jobs:
kubectl create namespace ${{ env.DSPA_NAMESPACE }}
- name: Run tests
working-directory: ${{ env.SYSTEM_TESTS_DIR }}
working-directory: ${{ env.INTEGRATION_TESTS_DIR }}
env:
NAMESPACE: ${{ env.DSPA_NAMESPACE }}
DSPA_NAME: ${{ env.DSPA_NAME }}
run: |
go run github.com/onsi/ginkgo/v2/ginkgo --tags=test_systest -- -kubeconfig=$HOME/.kube/config -k8sApiServerHost=$(oc whoami --show-server) -DSPANamespace=${{ env.DSPA_NAMESPACE }} -DSPAPath=resources/dspa-lite.yaml -ginkgo.v
go run github.com/onsi/ginkgo/v2/ginkgo --tags=test_integration -- -kubeconfig=$HOME/.kube/config -k8sApiServerHost=$(oc whoami --show-server) -DSPANamespace=${{ env.DSPA_NAMESPACE }} -DSPAPath=resources/dspa-lite.yaml -ginkgo.v
- name: Clean up
run: |
Expand Down
8 changes: 4 additions & 4 deletions tests/README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# DSP System tests
# DSP Integration tests

In this folder you will find the DSP System tests. These tests are intended to be run against a live Kubernetes or OCP
In this folder you will find the DSP Integration tests. These tests are intended to be run against a live Kubernetes or OCP
cluster. They are also utilized in our KinD GitHub workflow (e.g. [kind-workflow])

The tests are scoped to an individual namespace and require the testing namespace to be created beforehand.
Expand Down Expand Up @@ -34,7 +34,7 @@ git clone git@github.com:opendatahub-io/data-science-pipelines-operator.git ${DS
make deploy

cd tests
go run github.com/onsi/ginkgo/v2/ginkgo --tags=test_systest -- \
go run github.com/onsi/ginkgo/v2/ginkgo --tags=test_integration -- \
-kubeconfig=${KUBECONFIG_PATH} \
-k8sApiServerHost=${TARGET_CLUSTER} \
-DSPANamespace=${TARGET_NAMESPACE} -DSPAPath=resources/dspa-lite.yaml \
Expand All @@ -47,7 +47,7 @@ For the impatient developer, you can use the following flag to skip DSPA install
changes to a live environment and run the tests against it:

```bash
go run github.com/onsi/ginkgo/v2/ginkgo --tags=test_systest -- \
go run github.com/onsi/ginkgo/v2/ginkgo --tags=test_integration -- \
-kubeconfig=${KUBECONFIG_PATH} \
-k8sApiServerHost=${TARGET_CLUSTER} \
-DSPANamespace=${TARGET_NAMESPACE} -DSPAPath=resources/dspa-lite.yaml \
Expand Down
4 changes: 2 additions & 2 deletions tests/dspa_test.go
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
//go:build test_systest
//go:build test_integration

/*
Copyright 2023.
Expand All @@ -16,7 +16,7 @@ See the License for the specific language governing permissions and
limitations under the License.
*/

package systemtests
package integration

import (
"fmt"
Expand Down
4 changes: 2 additions & 2 deletions tests/experiments_test.go
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
//go:build test_systest
//go:build test_integration

/*
Copyright 2023.
Expand All @@ -16,7 +16,7 @@ See the License for the specific language governing permissions and
limitations under the License.
*/

package systemtests
package integration

import (
"fmt"
Expand Down
4 changes: 2 additions & 2 deletions tests/main.go
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
//go:build test_systest
//go:build test_integration

/*
Copyright 2023.
Expand All @@ -16,6 +16,6 @@ See the License for the specific language governing permissions and
limitations under the License.
*/

package systemtests
package integration

// This file only exists as a workaround for: https://github.com/dnephin/pre-commit-golang/issues/78
4 changes: 2 additions & 2 deletions tests/pipeline_test.go
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
//go:build test_systest
//go:build test_integration

/*
Copyright 2023.
Expand All @@ -16,7 +16,7 @@ See the License for the specific language governing permissions and
limitations under the License.
*/

package systemtests
package integration

import (
"fmt"
Expand Down
4 changes: 2 additions & 2 deletions tests/suite_test.go
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
//go:build test_systest
//go:build test_integration

/*
Copyright 2023.
Expand All @@ -16,7 +16,7 @@ See the License for the specific language governing permissions and
limitations under the License.
*/

package systemtests
package integration

import (
"context"
Expand Down

0 comments on commit cdd4e81

Please sign in to comment.