Skip to content

Commit

Permalink
Minute simplification of bool comparisons
Browse files Browse the repository at this point in the history
Signed-off-by: Achyut Madhusudan <amadhusu@redhat.com>
  • Loading branch information
Achyut Madhusudan committed Jul 25, 2024
1 parent bd8b98f commit 2d1e55e
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions controllers/dspipeline_controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -176,15 +176,15 @@ func (r *DSPAReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctrl.

dspa := &dspav1alpha1.DataSciencePipelinesApplication{}
err := r.Get(ctx, req.NamespacedName, dspa)
if err != nil && config.DSPAdeleted[req.Name] == false && apierrs.IsNotFound(err) {
if err != nil && !config.DSPAdeleted[req.Name] && apierrs.IsNotFound(err) {
log.Info("DSPA resource was not found")
return ctrl.Result{}, nil
} else if err != nil && config.DSPAdeleted[req.Name] == false {
} else if err != nil && !config.DSPAdeleted[req.Name] {
log.Error(err, "Encountered error when fetching DSPA")
return ctrl.Result{}, err
} else if config.DSPAdeleted[req.Name] == true && !apierrs.IsNotFound(err) {
} else if config.DSPAdeleted[req.Name] && !apierrs.IsNotFound(err) {
config.DSPAdeleted[req.Name] = false
} else if config.DSPAdeleted[req.Name] == true {
} else if config.DSPAdeleted[req.Name] {
return ctrl.Result{}, nil
}

Expand Down Expand Up @@ -333,7 +333,7 @@ func (r *DSPAReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctrl.
}
r.PublishMetrics(dspa, metricsMap)

if !dspaPrereqsReady && config.DSPAdeleted[req.Name] == false {
if !dspaPrereqsReady && !config.DSPAdeleted[req.Name] {
log.Info(fmt.Sprintf("Health check for Database or Object Store failed, retrying in %d seconds.", int(requeueTime.Seconds())))

return ctrl.Result{Requeue: true, RequeueAfter: requeueTime}, nil
Expand Down

0 comments on commit 2d1e55e

Please sign in to comment.