Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync with pcf/cfo Dec 11th #33

Merged
merged 0 commits into from
Dec 13, 2023

Conversation

ChristianZaccaria
Copy link

Description

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Copy link

openshift-ci bot commented Dec 11, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign jbusche for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@astefanutti
Copy link

/retest

@astefanutti
Copy link

/lgtm

@sutaakar
Copy link

I think it could be better to merge project-codeflare#398 first

@ChristianZaccaria
Copy link
Author

@sutaakar I could wait for that PR to merge. The purpose of this particular sync is to bring upstream to red-hat-data-services/CFO to get real Snyk reports (Snyk is currently only performing scans on rhds/cfo repo).

Meaning, after the sync, I might have a PR on upstream to solve the CVEs we have, then re-sync as necessary and have downstream repos free of critical/high CVEs as soon as possible. During those re-syncs, if that PR is merged I could bring it over, what do you think?

@ChristianZaccaria
Copy link
Author

@sutaakar would you know why the CI is failing? Logs show null pointer exception but don't understand why

@sutaakar
Copy link

Meaning, after the sync, I might have a PR on upstream to solve the CVEs we have, then re-sync as necessary and have downstream repos free of critical/high CVEs as soon as possible. During those re-syncs, if that PR is merged I could bring it over, what do you think?

Oh, ok. I though that this is for a release purposes.
Fine for me to merge it without 398.

@sutaakar
Copy link

@sutaakar would you know why the CI is failing? Logs show null pointer exception but don't understand why

Looks like a bug in a test function checking that Route is ready for requests. Will take a look on that later.

In the meantime lets retrigger the PR check:

/retest

@astefanutti
Copy link

@sutaakar @ChristianZaccaria are you ok to have that PR merged manually?

@sutaakar
Copy link

it is fine for me, tests were passing (except for that one)

@astefanutti
Copy link

@sutaakar We've commented at the same time :) Let's wait for the retest.

@ChristianZaccaria
Copy link
Author

Let's then wait on CI test, then let's merge it!

Copy link

openshift-ci bot commented Dec 12, 2023

@ChristianZaccaria: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-odh-cfo cab51dc link true /test e2e-odh-cfo

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ChristianZaccaria
Copy link
Author

Test failed with same nil pointer error

@astefanutti
Copy link

OK let's merge it manually.

@astefanutti
Copy link

@ChristianZaccaria GitHub doesn't seem to be able to merge it, which is not surprising for such a rebase. We'll have to force push the branch.

@ChristianZaccaria
Copy link
Author

@astefanutti before I make a mistake, I suppose this is what we want? :

I'm in this branch (`sync-dec11`)
git push odh-cfo main --force

@sutaakar
Copy link

project-codeflare/codeflare-common#21 should show us reason for the test failure.

@ChristianZaccaria ChristianZaccaria merged commit cab51dc into opendatahub-io:main Dec 13, 2023
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants