-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync with pcf/cfo Dec 11th #33
Sync with pcf/cfo Dec 11th #33
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/lgtm |
I think it could be better to merge project-codeflare#398 first |
@sutaakar I could wait for that PR to merge. The purpose of this particular sync is to bring upstream to red-hat-data-services/CFO to get real Snyk reports (Snyk is currently only performing scans on rhds/cfo repo). Meaning, after the sync, I might have a PR on upstream to solve the CVEs we have, then re-sync as necessary and have downstream repos free of critical/high CVEs as soon as possible. During those re-syncs, if that PR is merged I could bring it over, what do you think? |
@sutaakar would you know why the CI is failing? Logs show null pointer exception but don't understand why |
Oh, ok. I though that this is for a release purposes. |
Looks like a bug in a test function checking that Route is ready for requests. Will take a look on that later. In the meantime lets retrigger the PR check: /retest |
@sutaakar @ChristianZaccaria are you ok to have that PR merged manually? |
it is fine for me, tests were passing (except for that one) |
@sutaakar We've commented at the same time :) Let's wait for the retest. |
Let's then wait on CI test, then let's merge it! |
@ChristianZaccaria: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Test failed with same nil pointer error |
OK let's merge it manually. |
@ChristianZaccaria GitHub doesn't seem to be able to merge it, which is not surprising for such a rebase. We'll have to force push the branch. |
@astefanutti before I make a mistake, I suppose this is what we want? :
|
project-codeflare/codeflare-common#21 should show us reason for the test failure. |
037e70a
to
cab51dc
Compare
Description
How Has This Been Tested?
Merge criteria: