Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instructions to enable metrics for caikit tgis #29

Merged

Conversation

VedantMahabaleshwarkar
Copy link
Contributor

@VedantMahabaleshwarkar VedantMahabaleshwarkar commented Jul 20, 2023

Issues

Description

  • Updated caikit-tgis-serving image to the latest one available
  • Added optional environment variable in the Serving Runtime that is required to enable CPU only inferencing
  • Added instructions and resources needed to enable caikit metrics

How Has This Been Tested?

  • Tested a fresh Kserve(ODH deployment) + Serverless + ServiceMesh deployment
  • Deployed ServingRuntime and ISVC according to the demo files
  • Followed instructions added in the readme
  • Verified metrics show up in Openshift Console

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@openshift-ci openshift-ci bot requested review from anishasthana and Xaenalt July 20, 2023 20:12
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: VedantMahabaleshwarkar, Xaenalt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [VedantMahabaleshwarkar,Xaenalt]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 92001ad into opendatahub-io:main Jul 20, 2023
@heyselbi heyselbi linked an issue Jul 20, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[P0] Verify which metrics CAIKit/TGIS produce
3 participants