Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Guild #97

Closed
Supacek opened this issue Nov 6, 2022 · 30 comments · Fixed by #102
Closed

Create Guild #97

Supacek opened this issue Nov 6, 2022 · 30 comments · Fixed by #102

Comments

@Supacek
Copy link

Supacek commented Nov 6, 2022

yo guys is Create guild working i dont think so its not seen ingame did someone test it ?

@xDezossAx
Copy link

image
Here there was an error when creating, the sharedserver crashed.

@Supacek
Copy link
Author

Supacek commented Nov 7, 2022

Wrong Query there isnt 'intro' default in database table GuildMembers so i set it to 0 default but after that no error the database is working im member of the guild now but still dont see it in guild list or cannot open anythink :/

@xDezossAx
Copy link

Wrong Query there isnt 'intro' default in database table GuildMembers so i set it to 0 default but after that no error the database is working im member of the guild now but still dont see it in guild list or cannot open anythink :/

I also changed the Intro column to accept null, but even though I am Guild Leader and member, I can't see it.

@Supacek
Copy link
Author

Supacek commented Nov 7, 2022

image
didnt find anythink else i dont know wheres problem :/

@xDezossAx
Copy link

I did a test on other files, and it returns the following when creating a guild:

Receive:CGRegistGuild(GuildName:BYEBYEGuildIntro:WELCOME TO THE JUNGLE)
Receive:GSAddGuild (GuildName:BYEBYE
GuildMaster:▒▒▒▒▒▒▒▒
GuildIntro:WELCOME TO THE JUNGLE
GuildState:1
GuildRace:0ServerGroupID:0 )
Receive:SGAddGuildOK(
GuildID:25580
GuildName:BYEBYE
GuildRace:0
GuildState:1
GuildZoneID:16052
GuildMaster:▒▒▒▒▒▒▒▒
GuildIntro:WELCOME TO THE JUNGLE)
Receive:SGAddGuildMemberOK(
GuildID:25580Name:▒▒▒▒▒▒▒▒
GuildMemberRank:1)
Receive:CGVerifyTime()

and returns this when I enter the guild wait list

Receive:CGSelectGuild(GuildID:25580)

I think it has something to do with the file: SGAddGuildOK.* '-'

@xDezossAx
Copy link

in SGAddGuildOK.cpp exist this line "#ifdef GAME_SERVER" if you comment her should work
void SGAddGuildOK::execute (Player * pPlayer )
{

//#ifdef GAME_SERVER

__BEGIN_TRY
	
SGAddGuildOKHandler::execute(this);
	
__END_CATCH

//#endif
}

the same should do with the SGAddGuildMemberOK, I'm going to sleep now later test

@Supacek
Copy link
Author

Supacek commented Nov 8, 2022

image

@xDezossAx
Copy link

in the makefile you have to reference it when creating the libsharedserverpackets.a, when i get home i will test.

@Supacek
Copy link
Author

Supacek commented Nov 10, 2022

in the makefile you have to reference it when creating the libsharedserverpackets.a, when i get home i will test.

did u test it is it working ?

@xDezossAx
Copy link

@Supacek These are the same files here, only with the Cpackets, Gpackets, Lpackets, Spackets folders restored, just send the make depall command and then run make in this version you will see that the GuildWait List and Guild List work normally. you can have a base to adjust this without the respective folders. also tests the "Recall Motorcycle problem"
src.zip
GuildInfo.zip

@Supacek
Copy link
Author

Supacek commented Nov 11, 2022

im so glad u trying help but i dont like those files theres so many copy files some of them are like 5x same i dont know this type of src can u please like try to stay with the same files and help me what to do ? sorry my english still sux.,.

@Supacek
Copy link
Author

Supacek commented Nov 11, 2022

im trying scan the files what we have but it looks same the problem is only maybe in the make file ?

@xDezossAx
Copy link

@Supacek these zip files is the same here, but with the restored folders, you can get what works in this base to correct the files here, the inclusion of files changes in the compiled librarys. I took advantage of the makefile of other files in these files here from opendarkeden :)

@xDezossAx
Copy link

there must be somewhere, where I inform the GCActiveGuildList and GCWaitGuildList, but I haven't had time to tinker with it yet.

@Supacek
Copy link
Author

Supacek commented Nov 11, 2022

is it working with the same client and the server core?

@xDezossAx
Copy link

xDezossAx commented Nov 11, 2022

is it working with the same client and the server core?

yes, same cliente same files 👍 , I'll try to adjust it at home without needing the folders again, but this one is good for testing bugs, it could also be something related to the CGRequestGuild

@Supacek
Copy link
Author

Supacek commented Nov 11, 2022

i scan the files and theres nothing it must by another files

@Supacek
Copy link
Author

Supacek commented Nov 11, 2022

Cant even Quit Guild
image

@Supacek
Copy link
Author

Supacek commented Nov 14, 2022

still didnt figure it out im done lol :/

@NEW-BOY1
Copy link

NEW-BOY1 commented Nov 14, 2022

When you create guild
. Need your 5 friends support. To be successful

@Supacek
Copy link
Author

Supacek commented Nov 14, 2022

When you create guild . Need your 5 friends support. To be successful

the guild is created in database but didnt opening in game

@Supacek
Copy link
Author

Supacek commented Nov 14, 2022

image
no Guild

@Supacek
Copy link
Author

Supacek commented Nov 14, 2022

image

@Supacek
Copy link
Author

Supacek commented Nov 14, 2022

cant even open Clan info nothink
image

@NEW-BOY1
Copy link

You may try the game created within the guild

@Supacek
Copy link
Author

Supacek commented Nov 15, 2022

is it working with the same client and the server core?

yes, same cliente same files 👍 , I'll try to adjust it at home without needing the folders again, but this one is good for testing bugs, it could also be something related to the CGRequestGuild

hallo, did u trz it without the files ? i need telp to figure out this the Guild is importent for me..

@Supacek
Copy link
Author

Supacek commented Nov 15, 2022

Tested in other Server Files
image
Like i dont even get those messages about u
image
or
image

VS our

image

@Supacek
Copy link
Author

Supacek commented Nov 18, 2022

image
SGGuildInfo.cpp commend it

//////////////////////////////////////////////////////////////////////
// execute packet's handler
//////////////////////////////////////////////////////////////////////
void SGGuildInfo::execute (Player * pPlayer )
{

//#ifdef GAME_SERVER

__BEGIN_TRY
	
SGGuildInfoHandler::execute(this);
	
__END_CATCH

//#endif
}

FIXED !!!

tiancaiamao added a commit that referenced this issue Nov 25, 2022
#97
It's caused by the makefile __GAME_SERVER__ macro define
Also the Rank is a reserved keyword in MySQL8, need to add quote to the SQL.
@Supacek
Copy link
Author

Supacek commented Dec 13, 2022

its not working did u test it ? it create guild after restart but its not working normaly theres no message nothink

@tiancaiamao
Copy link
Contributor

its not working did u test it ? it create guild after restart but its not working normaly theres no message nothink

Are you using the latest version? I've tested it and it should have been fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants