-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Palo Alto Cortext XDR UDI Connector #858
Added Palo Alto Cortext XDR UDI Connector #858
Conversation
Added Palo Alto Cortext XDR UDI Connector with updated fork.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please fix the unittests. I see few are failing in. stix-shifter/stix_shifter_modules/paloalto/tests/stix_transmission/test_paloalto.py
stix_shifter_modules/paloalto/stix_translation/query_constructor.py
Outdated
Show resolved
Hide resolved
stix_shifter_modules/paloalto/stix_transmission/results_connector.py
Outdated
Show resolved
Hide resolved
} | ||
}, | ||
"quota_threshold": { | ||
"default": 3.00, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is the default value 3.00?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To reserve only 60% of the license quota (5) to the API call, it is set to 3. Now the user is allowed to provide values between 1 and 4 in the CP4S UI. As discussed, additional quota threshold configuration is also available.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you leave a comment on this line stating that the regular license API quota is 5 so anyone seeing this knows what it's for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added details in lang_en.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed in the status call, additional quota configuration is merged with 'quota_threshold' configuration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed, updated x-oca-asset and x-oca-event mappings.
Updated PaloAlto Transmit Unit test Cases
Updated Transmit unit test file
1. Added support for more than 1000 records using stream API as discussed. 2. Updated Stix 2.1 to_stix_map.json with the modified format extensions 3. Added Quota Limit for API calls based on License.
Codecov Report
@@ Coverage Diff @@
## develop #858 +/- ##
===========================================
+ Coverage 63.41% 63.71% +0.30%
===========================================
Files 467 483 +16
Lines 41733 44069 +2336
===========================================
+ Hits 26466 28080 +1614
- Misses 15267 15989 +722
Continue to review full report at Codecov.
|
The failed test cases are fixed and passed. |
Updated the Standard daily License API quota details
Updated 'quota_threshold' configuration value
updated the mappings of x-oca-event and x-oca-asset fields
Added Palo Alto Cortext XDR UDI Connector with updated fork.