Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Palo Alto Cortext XDR UDI Connector #858

Merged

Conversation

lakshmi51974368
Copy link
Contributor

Added Palo Alto Cortext XDR UDI Connector with updated fork.

lakshmi51974368 and others added 2 commits March 18, 2022 14:48
Added Palo Alto Cortext XDR UDI Connector with updated fork.
Copy link
Member

@mdazam1942 mdazam1942 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix the unittests. I see few are failing in. stix-shifter/stix_shifter_modules/paloalto/tests/stix_transmission/test_paloalto.py

}
},
"quota_threshold": {
"default": 3.00,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is the default value 3.00?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To reserve only 60% of the license quota (5) to the API call, it is set to 3. Now the user is allowed to provide values between 1 and 4 in the CP4S UI. As discussed, additional quota threshold configuration is also available.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you leave a comment on this line stating that the regular license API quota is 5 so anyone seeing this knows what it's for?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added details in lang_en.json

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed in the status call, additional quota configuration is merged with 'quota_threshold' configuration.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, updated x-oca-asset and x-oca-event mappings.

lakshmi51974368 and others added 5 commits March 22, 2022 12:44
Updated PaloAlto Transmit Unit test Cases
Updated Transmit unit test file
1. Added support for more than 1000 records using stream API as discussed.
2. Updated Stix 2.1 to_stix_map.json with the modified format extensions
3. Added Quota Limit for API calls based on License.
@codecov
Copy link

codecov bot commented Mar 24, 2022

Codecov Report

Merging #858 (72e2671) into develop (4ff9573) will increase coverage by 0.30%.
The diff coverage is 93.23%.

@@             Coverage Diff             @@
##           develop     #858      +/-   ##
===========================================
+ Coverage    63.41%   63.71%   +0.30%     
===========================================
  Files          467      483      +16     
  Lines        41733    44069    +2336     
===========================================
+ Hits         26466    28080    +1614     
- Misses       15267    15989     +722     
Impacted Files Coverage Δ
...r_modules/paloalto/stix_transmission/api_client.py 44.11% <78.12%> (ø)
..._modules/paloalto/stix_translation/transformers.py 80.00% <80.00%> (ø)
...les/paloalto/stix_transmission/delete_connector.py 80.00% <80.00%> (ø)
...ules/paloalto/stix_transmission/response_mapper.py 53.21% <85.29%> (ø)
...es/paloalto/stix_transmission/results_connector.py 53.28% <86.25%> (ø)
...les/paloalto/stix_translation/query_constructor.py 77.74% <89.31%> (ø)
...modules/paloalto/stix_transmission/error_mapper.py 81.81% <90.00%> (ø)
...ules/paloalto/stix_transmission/query_connector.py 90.00% <90.00%> (ø)
...les/paloalto/stix_transmission/status_connector.py 89.02% <91.25%> (ø)
...ts/stix_translation/test_paloalto_stix_to_query.py 73.33% <96.35%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ff9573...72e2671. Read the comment docs.

@lakshmi51974368
Copy link
Contributor Author

please fix the unittests. I see few are failing in. stix-shifter/stix_shifter_modules/paloalto/tests/stix_transmission/test_paloalto.py

The failed test cases are fixed and passed.

@delliott90 delliott90 merged commit f00e8e6 into opencybersecurityalliance:develop Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants