-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
results metadata support #813
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #813 +/- ##
===========================================
- Coverage 63.52% 63.49% -0.04%
===========================================
Files 468 468
Lines 41671 41700 +29
===========================================
+ Hits 26472 26477 +5
- Misses 15199 15223 +24
Continue to review full report at Codecov.
|
#METADATA_SAMPLE else: | ||
#METADATA_SAMPLE metadata = {} | ||
#METADATA_SAMPLE metadata_result_id += 1 | ||
#METADATA_SAMPLE metadata['metadata_result_id'] = metadata_result_id |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trying to understand this usage-
- what is the use of
metadata_result_id
? - why does it have to be integer?
- why are you incrementing the id?
- what if there's a different key other than
metadata_result_id
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is just a sample, any data can be returned in metadata status. That returned metadata will be provided to future status and results calls.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think, this example would confuse people. Also, I would put example inside dummy connectors instead of stix-bundle stix_shifter_modules/synchronous_dummy
/ stix_shifter_modules/async_dummy
No description provided.