Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New UDI connector module for IBM Security Verify #802

Merged
merged 27 commits into from
Mar 4, 2022

Conversation

kr-riteshsinha
Copy link
Contributor

This Pull has been requested for module verify which is developed to communicate with IBM Security Verify.
Please review and let us know if any changes are required.

@delliott90
Copy link
Collaborator

Should the previous PR be closed? #785

@codecov
Copy link

codecov bot commented Feb 4, 2022

Codecov Report

Merging #802 (82ffba8) into develop (521bb1d) will decrease coverage by 0.29%.
The diff coverage is 71.42%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #802      +/-   ##
===========================================
- Coverage    63.99%   63.69%   -0.30%     
===========================================
  Files          437      452      +15     
  Lines        39038    39886     +848     
===========================================
+ Hits         24981    25406     +425     
- Misses       14057    14480     +423     
Impacted Files Coverage Δ
..._security_verify/stix_transmission/error_mapper.py 0.00% <0.00%> (ø)
...bm_security_verify/stix_transmission/api_client.py 16.05% <19.13%> (ø)
...urity_verify/stix_translation/query_constructor.py 41.92% <75.77%> (ø)
...ecurity_verify/stix_transmission/ping_connector.py 80.95% <80.95%> (ø)
...rity_verify/stix_transmission/results_connector.py 70.96% <81.48%> (ø)
...urity_verify/stix_transmission/delete_connector.py 87.50% <87.50%> (ø)
...test/stix_translation/test_ibm_verify_transform.py 50.54% <88.46%> (ø)
.../stix_transmission/test_ibm_verify_transmission.py 67.24% <97.50%> (ø)
...shifter_modules/ibm_security_verify/entry_point.py 100.00% <100.00%> (ø)
...curity_verify/stix_translation/query_translator.py 81.81% <100.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 521bb1d...82ffba8. Read the comment docs.

@kr-riteshsinha
Copy link
Contributor Author

Should the previous PR be closed? #785

I have closed pull request #785

Copy link
Member

@mdazam1942 mdazam1942 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the full product name is IBM Security Verify then I would change the module name to ibm_security_verify instead of just verify.

requirements.txt Outdated Show resolved Hide resolved
"extensions.'x-iam-ext'.location_lon":["geoip.location.lon"],
"extensions.'x-iam-ext'.location_lat":["geoip.location_lat"],
"extensions.'x-iam-ext'.city_name": ["geoip.city_name"],
"extensions.'x-iam-ext'.'policy_action'":["data.policy_action"],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You only need the single quotes around properties with dashes, like 'x-iam-ext', you don't need them on policy_action etc. since those use _ not -.

Copy link
Member

@mdazam1942 mdazam1942 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

build needs to be fixed. failure in unittests

kr-riteshsinha and others added 4 commits February 22, 2022 22:18
Test case is failing because of duplicate test case name in other module.
Test case is failing because pytest found duplicate filename in other module.
Copy link
Member

@mdazam1942 mdazam1942 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kr-riteshsinha can you please add stix 2.1 mappings as well? here's the example: https://github.com/opencybersecurityalliance/stix-shifter/tree/develop/stix_shifter_modules/qradar/stix_translation/json/stix_2_1
you can follow this stix2.1 documentation for major changes https://docs.oasis-open.org/cti/stix/v2.1/csprd01/stix-v2.1-csprd01.html#_Toc16070580

Reach out to us if you have difficulty to create 2.1 mappings.

@mdazam1942 mdazam1942 merged commit 95f4cee into opencybersecurityalliance:develop Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants