-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New UDI connector module for IBM Security Verify #802
New UDI connector module for IBM Security Verify #802
Conversation
Should the previous PR be closed? #785 |
Codecov Report
@@ Coverage Diff @@
## develop #802 +/- ##
===========================================
- Coverage 63.99% 63.69% -0.30%
===========================================
Files 437 452 +15
Lines 39038 39886 +848
===========================================
+ Hits 24981 25406 +425
- Misses 14057 14480 +423
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the full product name is IBM Security Verify then I would change the module name to ibm_security_verify
instead of just verify
.
stix_shifter_modules/verify/stix_translation/json/from_stix_map.json
Outdated
Show resolved
Hide resolved
stix_shifter_modules/verify/stix_translation/json/from_to_stix_1.8.json
Outdated
Show resolved
Hide resolved
stix_shifter_modules/verify/stix_translation/json/to_stix_map.json
Outdated
Show resolved
Hide resolved
stix_shifter_modules/verify/stix_transmission/query_connector.py
Outdated
Show resolved
Hide resolved
stix_shifter_modules/verify/stix_transmission/results_connector.py
Outdated
Show resolved
Hide resolved
"extensions.'x-iam-ext'.location_lon":["geoip.location.lon"], | ||
"extensions.'x-iam-ext'.location_lat":["geoip.location_lat"], | ||
"extensions.'x-iam-ext'.city_name": ["geoip.city_name"], | ||
"extensions.'x-iam-ext'.'policy_action'":["data.policy_action"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You only need the single quotes around properties with dashes, like 'x-iam-ext'
, you don't need them on policy_action
etc. since those use _
not -
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
build needs to be fixed. failure in unittests
Test case is failing because of duplicate test case name in other module.
Test case is failing because pytest found duplicate filename in other module.
stix_shifter_modules/ibm_security_verify/stix_translation/query_constructor.py
Outdated
Show resolved
Hide resolved
stix_shifter_modules/ibm_security_verify/stix_translation/query_constructor.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kr-riteshsinha can you please add stix 2.1 mappings as well? here's the example: https://github.com/opencybersecurityalliance/stix-shifter/tree/develop/stix_shifter_modules/qradar/stix_translation/json/stix_2_1
you can follow this stix2.1 documentation for major changes https://docs.oasis-open.org/cti/stix/v2.1/csprd01/stix-v2.1-csprd01.html#_Toc16070580
Reach out to us if you have difficulty to create 2.1 mappings.
This Pull has been requested for module verify which is developed to communicate with IBM Security Verify.
Please review and let us know if any changes are required.