Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Placeholder for datadog certificate changed #782

Merged
merged 7 commits into from
Jan 21, 2022
Merged

Placeholder for datadog certificate changed #782

merged 7 commits into from
Jan 21, 2022

Conversation

pramodgslab
Copy link
Contributor

No description provided.

mdazam1942
mdazam1942 suggested changes Jan 20, 2022
View reviewed changes
Copy link
Member

@mdazam1942 mdazam1942 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to handle empty or non-empty selfSignedCert cases in your api_client not in config.json

stix_shifter_modules/datadog/configuration/lang_en.json Outdated Show resolved Hide resolved
stix_shifter_modules/datadog/configuration/config.json Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jan 21, 2022 •
edited
Loading

Codecov Report

Merging #782 (89cc95a) into develop (b37a77a) will not change coverage.
The diff coverage is 25.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #782   +/-   ##
========================================
  Coverage    64.37%   64.37%           
========================================
  Files          425      425           
  Lines        36518    36518           
========================================
  Hits         23510    23510           
  Misses       13008    13008
Impacted Files Coverage Δ
...er_modules/datadog/stix_transmission/api_client.py 32.78% <25.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b37a77a...89cc95a. Read the comment docs.

@pramodgslab
Copy link
Contributor Author

pramodgslab commented Jan 21, 2022 •
edited
Loading

@mdazam1942 with this changes user can skip selfSignedCert or paste certificate.

@mdazam1942 mdazam1942 merged commit 8a1d986 into opencybersecurityalliance:develop Jan 21, 2022
mdazam1942 pushed a commit that referenced this pull request Feb 3, 2022
@pramodgslab @mdazam1942
Placeholder for datadog certificate changed (#782)
4426415
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdazam1942 mdazam1942 mdazam1942 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pramodgslab @mdazam1942