Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datadog ssl cert fix #758

Merged

Conversation

shahvs
Copy link
Contributor

@shahvs shahvs commented Dec 20, 2021

No description provided.

@codecov
Copy link

codecov bot commented Dec 20, 2021

Codecov Report

Merging #758 (3f36c94) into develop (f0cfc05) will decrease coverage by 0.00%.
The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #758      +/-   ##
===========================================
- Coverage    63.34%   63.34%   -0.01%     
===========================================
  Files          425      425              
  Lines        36854    36862       +8     
===========================================
+ Hits         23345    23349       +4     
- Misses       13509    13513       +4     
Impacted Files Coverage Δ
...les/datadog/test/stix_transmission/test_datadog.py 68.65% <ø> (ø)
...er_modules/datadog/stix_transmission/api_client.py 32.78% <50.00%> (+2.59%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0cfc05...3f36c94. Read the comment docs.

@@ -7,6 +7,10 @@
"type": "text",
"regex": "https?:\\/\\/((app|us3|us5)\\.)[a-z0-9-]+\\.[a-z]{2,3}$"
},
"selfSignedCert": {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You will also need to have an entry in the lang_en.json file. Example

"selfSignedCert": {
            "label": "Datadog Certificate",
            "placeholder": "Paste your certificate"
        }

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added certificate entry in lang_en.json

@delliott90 delliott90 merged commit 860ac44 into opencybersecurityalliance:develop Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants