-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CrowdStrike Logscale UDI Connector #1631
CrowdStrike Logscale UDI Connector #1631
Conversation
Added UDI connector for CrowdStrike Logscale data source
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1631 +/- ##
===========================================
+ Coverage 86.26% 86.52% +0.25%
===========================================
Files 586 600 +14
Lines 50040 51314 +1274
===========================================
+ Hits 43166 44397 +1231
- Misses 6874 6917 +43 ☔ View full report in Codecov by Sentry. |
Updated the code to fix python 3.8 test failure
Added a boolean parameter - combined_observation to handle different qualifiers to handle filter functions.
...hifter_modules/crowdstrike_logscale/stix_translation/json/crowdstrike_edr_from_stix_map.json
Outdated
Show resolved
Hide resolved
1. Updated the dialect name crowdstrik_edr to crowdstrikeedr in mapping files. 2. Updated unit test case files, config file, read me, entry point files with respect to change in dialect name.
stix_shifter_modules/crowdstrike_logscale/stix_translation/transformers.py
Show resolved
Hide resolved
stix_shifter_modules/crowdstrike_logscale/stix_translation/transformers.py
Outdated
Show resolved
Hide resolved
stix_shifter_modules/crowdstrike_logscale/configuration/config.json
Outdated
Show resolved
Hide resolved
stix_shifter_modules/crowdstrike_logscale/configuration/config.json
Outdated
Show resolved
Hide resolved
stix_shifter_modules/crowdstrike_logscale/configuration/lang_en.json
Outdated
Show resolved
Hide resolved
stix_shifter_modules/crowdstrike_logscale/stix_translation/json/crowdstrikeedr_to_stix_map.json
Show resolved
Hide resolved
Modified the transformer of MAC- address and updated the config files with respect to repository. Changes corresponding to config has been done in transmit files and read-me files. Updated except class to reuse the exception_response function in connector.py file
…MS-Hcl/stix-shifter into crowdstrike_logscale_v1
stix_shifter_modules/crowdstrike_logscale/configuration/lang_en.json
Outdated
Show resolved
Hide resolved
updated transformer and readme file based on review comments
Updated the error codes in read me and added back the connector extension details.
stix_shifter_modules/crowdstrike_logscale/stix_transmission/connector.py
Outdated
Show resolved
Hide resolved
stix_shifter_modules/crowdstrike_logscale/stix_transmission/connector.py
Outdated
Show resolved
Hide resolved
added connector name in logger error
Updated the connector with Pagination logic and updated unit test cases, readme files.
stix_shifter_modules/crowdstrike_logscale/stix_translation/transformers.py
Show resolved
Hide resolved
stix_shifter_modules/crowdstrike_logscale/stix_translation/query_constructor.py
Outdated
Show resolved
Hide resolved
stix_shifter_modules/crowdstrike_logscale/stix_transmission/api_client.py
Outdated
Show resolved
Hide resolved
stix_shifter_modules/crowdstrike_logscale/stix_transmission/query_connector.py
Show resolved
Hide resolved
stix_shifter_modules/crowdstrike_logscale/stix_transmission/delete_connector.py
Outdated
Show resolved
Hide resolved
stix_shifter_modules/crowdstrike_logscale/stix_transmission/results_connector.py
Outdated
Show resolved
Hide resolved
stix_shifter_modules/crowdstrike_logscale/stix_transmission/results_connector.py
Show resolved
Hide resolved
stix_shifter_modules/crowdstrike_logscale/stix_transmission/api_client.py
Show resolved
Hide resolved
stix_shifter_modules/crowdstrike_logscale/stix_transmission/query_connector.py
Show resolved
Hide resolved
Updated the code and unit test cases accordingly
updated the code and unit test cases with pagination
stix_shifter_modules/crowdstrike_logscale/stix_transmission/results_connector.py
Show resolved
Hide resolved
stix_shifter_modules/crowdstrike_logscale/configuration/lang_en.json
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good. Thanks for taking the time to implement the suggested changes. I'll approve the PR.
af474b6
into
opencybersecurityalliance:develop
Added UDI connector module for CrowdStrike Logscale data source.