Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make aws access ids optional to support assume role authencation #1629

Merged
merged 3 commits into from
Jan 24, 2024

Conversation

mdazam1942
Copy link
Member

and remove verify connection false

@mdazam1942 mdazam1942 marked this pull request as draft December 11, 2023 20:44
Copy link

codecov bot commented Dec 11, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (9d375f9) 86.19% compared to head (f18c4c2) 86.19%.

Files Patch % Lines
...dules/aws_athena/stix_transmission/boto3_client.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1629      +/-   ##
===========================================
- Coverage    86.19%   86.19%   -0.01%     
===========================================
  Files          582      582              
  Lines        49784    49783       -1     
===========================================
- Hits         42912    42911       -1     
  Misses        6872     6872              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mdazam1942 mdazam1942 marked this pull request as ready for review January 24, 2024 13:53
@mdazam1942 mdazam1942 merged commit d55a40f into develop Jan 24, 2024
9 checks passed
@mdazam1942 mdazam1942 deleted the athena_client_update branch January 24, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant