remove cybox false flag for observed-data properties #1502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #1502 +/- ##
===========================================
- Coverage 85.17% 85.16% -0.01%
===========================================
Files 679 679
Lines 53146 53148 +2
===========================================
- Hits 45267 45264 -3
- Misses 7879 7884 +5
☔ View full report in Codecov by Sentry. |
mdazam1942
reviewed
Jun 6, 2023
| @@ -66,7 +66,7 @@ def __init__(self, data_source, ds_to_stix_map, transformers, options, callback= | |||
| self.callback = callback | |||
|
|
|||
| # parse through options | |||
| self.cybox_default = options.get('cybox_default', True) | |||
| # self.cybox_default = options.get('cybox_default', True) | |||
There was a problem hiding this comment.
this line is not needed anymore. do you want to keep it for future reference since you commented out?
mdazam1942
approved these changes
Jun 7, 2023
…e/stix-shifter into cybox_false_fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.