Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Config changes for GCP Chronicle for develop branch #1476

Conversation

SharmilaMS-Hcl
Copy link
Contributor

  1. Updated Config and lang_en json files with private key(type as password) and email (type as text) under auth section.
  2. Updated Api client, unit test case for transmit and read me files.

1. Updated Config and lang_en json files with private key(type as password) and email (type as text) under auth section.
2. Updated Api client, unit test case for transmit and read me files.
@codecov
Copy link

codecov bot commented May 9, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.18 ⚠️

Comparison is base (05e7dd7) 85.44% compared to head (3e8d529) 85.27%.

❗ Current head 3e8d529 differs from pull request most recent head cb552ba. Consider uploading reports for the commit cb552ba to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1476      +/-   ##
===========================================
- Coverage    85.44%   85.27%   -0.18%     
===========================================
  Files          618      602      -16     
  Lines        46888    45606    -1282     
===========================================
- Hits         40064    38891    -1173     
+ Misses        6824     6715     -109     
Impacted Files Coverage Δ
...icle/tests/stix_transmission/test_gcp_chronicle.py 100.00% <ø> (ø)
...ules/gcp_chronicle/stix_transmission/api_client.py 92.79% <100.00%> (ø)

... and 21 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@delliott90 delliott90 merged commit 14b83a3 into opencybersecurityalliance:develop May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants