Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

to_stix_map validator #1469

Merged
merged 7 commits into from
May 10, 2023
Merged

Conversation

pcoccoli
Copy link
Contributor

@pcoccoli pcoccoli commented May 5, 2023

A work in progress really, but should still be useful.

@codecov
Copy link

codecov bot commented May 9, 2023

Codecov Report

Patch coverage: 85.49% and project coverage change: +0.17 🎉

Comparison is base (a21eaa7) 85.27% compared to head (683cf39) 85.44%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1469      +/-   ##
===========================================
+ Coverage    85.27%   85.44%   +0.17%     
===========================================
  Files          602      618      +16     
  Lines        45606    46888    +1282     
===========================================
+ Hits         38891    40064    +1173     
- Misses        6715     6824     +109     
Impacted Files Coverage Δ
...x_transmission/test_alienvault_otx_transmission.py 55.55% <55.55%> (ø)
...les/alienvault_otx/stix_transmission/api_client.py 57.75% <57.75%> (ø)
...ienvault_otx/stix_translation/query_constructor.py 79.51% <79.51%> (ø)
...envault_otx/stix_translation/results_translator.py 80.97% <80.97%> (ø)
.../alienvault_otx/stix_translation/sdo_translator.py 85.71% <85.71%> (ø)
...alienvault_otx/stix_transmission/ping_connector.py 86.36% <86.36%> (ø)
...ix_translation/test_alienvault_otx_json_to_stix.py 94.49% <94.49%> (ø)
...envault_otx/stix_transmission/results_connector.py 95.34% <95.34%> (ø)
stix_shifter_modules/alienvault_otx/entry_point.py 100.00% <100.00%> (ø)
...lienvault_otx/stix_translation/query_translator.py 100.00% <100.00%> (ø)
... and 6 more

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@delliott90
Copy link
Collaborator

Could you move the map_validator folder under the scripts folder?
https://github.com/opencybersecurityalliance/stix-shifter/tree/develop/stix_shifter/scripts

@mdazam1942
Copy link
Member

Could you move the map_validator folder under the scripts folder? https://github.com/opencybersecurityalliance/stix-shifter/tree/develop/stix_shifter/scripts

the scripts folder needs to be outside of stix_shifter at the root level. it would be easier to notice and access.

@mdazam1942 mdazam1942 merged commit 05e7dd7 into opencybersecurityalliance:develop May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants