Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get configs #1392

Merged
merged 3 commits into from
Mar 17, 2023
Merged

get configs #1392

merged 3 commits into from
Mar 17, 2023

Conversation

yurii-klymenko
Copy link
Collaborator

python -m main configs
or
stix-shifter configs

@codecov
Copy link

codecov bot commented Mar 16, 2023

Codecov Report

Patch coverage: 66.66% and project coverage change: -0.01 ⚠️

Comparison is base (19cd85f) 85.24% compared to head (327f257) 85.23%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1392      +/-   ##
===========================================
- Coverage    85.24%   85.23%   -0.01%     
===========================================
  Files          585      585              
  Lines        43751    43758       +7     
===========================================
+ Hits         37294    37298       +4     
- Misses        6457     6460       +3     
Impacted Files Coverage Δ
stix_shifter/stix_translation/stix_translation.py 83.89% <60.00%> (-1.19%) ⬇️
stix_shifter_utils/utils/base_entry_point.py 84.75% <75.00%> (-0.20%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@mdazam1942 mdazam1942 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it should have the option to get the config of a specified module as well instead of just getting all the module configs. like this-

python main.py configs qradar

@yurii-klymenko
Copy link
Collaborator Author

it is implemented the same way as
python -m main modules
so cli returns for all of them,
but in code you can do:
config = await stix_tranlation.translate_async('qradar', CONFIGS, {}, {}, {})
to fetch individual one

@yurii-klymenko
Copy link
Collaborator Author

yurii-klymenko commented Mar 17, 2023

added:
python -m main modules
python -m main modules qradar
python -m main configs
python -m main configs qradar

Copy link
Member

@mdazam1942 mdazam1942 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yurii-klymenko thanks for adding those extra arguments. looks great

@mdazam1942 mdazam1942 merged commit 244ce47 into develop Mar 17, 2023
@mdazam1942 mdazam1942 deleted the ss_get_configs branch March 17, 2023 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants