Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Splunk: Fix MAC address to display in proper STIX format #1386

Conversation

thangaraj-ramesh
Copy link
Contributor

Added transformer to handle any MAC value into Stix format. Added new unit test cases.
Added missed async await in api_client.

Added transformer to handle any MAC value into Stix format.
Added new unit test cases.
Added missed async await in api_client.
corrected test cases of build issue
@delliott90
Copy link
Collaborator

Can you rename this PR to something that would make sense to the open source community? This is an open project and no one knows what CP4SCORE-24254 means.

@delliott90
Copy link
Collaborator

We actually generate our CHANGELOGS from the merge commits on the PRs https://github.com/opencybersecurityalliance/stix-shifter/blob/develop/CHANGELOG.md

@thangaraj-ramesh thangaraj-ramesh changed the title Fix for issue CP4SCORE-24254 Splunk: Fix MAC address to display in proper STIX format Mar 14, 2023
@thangaraj-ramesh
Copy link
Contributor Author

As suggested PR is renamed.

@codecov
Copy link

codecov bot commented Mar 14, 2023

Codecov Report

Patch coverage: 78.57% and project coverage change: +0.01 🎉

Comparison is base (8795a37) 85.23% compared to head (03932e9) 85.24%.

❗ Current head 03932e9 differs from pull request most recent head 9a12077. Consider uploading reports for the commit 9a12077 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1386      +/-   ##
===========================================
+ Coverage    85.23%   85.24%   +0.01%     
===========================================
  Files          585      585              
  Lines        43758    43771      +13     
===========================================
+ Hits         37298    37314      +16     
+ Misses        6460     6457       -3     
Impacted Files Coverage Δ
...ter_modules/splunk/stix_transmission/api_client.py 35.84% <14.28%> (ø)
...er_modules/splunk/stix_translation/transformers.py 93.54% <100.00%> (+3.54%) ⬆️
...tests/stix_translation/test_splunk_json_to_stix.py 99.52% <100.00%> (+0.01%) ⬆️

... and 4 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

corrected the maclength variable spelling.
thangaraj-ramesh and others added 2 commits March 15, 2023 15:51
As suggested Mac address allowed literal changed to [A-Fa-f0-9].
A typo error in api_client file is corrected(character ] removed).
@delliott90 delliott90 merged commit b2e8dc4 into opencybersecurityalliance:develop Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants