Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Async changes for Okta UDI connector #1383

Merged

Conversation

SharmilaMS-Hcl
Copy link
Contributor

1.Added async changes for okta in connector.py file and api_client.py file.
2.Modified transmit unit test cases for the same.

1.Added async changes for okta in connector.py file and api_client.py file.
2.Modified transmit unit test cases for the same.
@codecov
Copy link

codecov bot commented Mar 10, 2023

Codecov Report

Patch coverage: 96.87% and project coverage change: -0.13 ⚠️

Comparison is base (c45d044) 85.32% compared to head (b281779) 85.20%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1383      +/-   ##
===========================================
- Coverage    85.32%   85.20%   -0.13%     
===========================================
  Files          585      585              
  Lines        43764    43738      -26     
===========================================
- Hits         37342    37267      -75     
- Misses        6422     6471      +49     
Impacted Files Coverage Δ
...ter_modules/okta/stix_transmission/error_mapper.py 100.00% <ø> (ø)
...hifter_modules/okta/stix_transmission/connector.py 91.39% <91.66%> (+0.08%) ⬆️
...ifter_modules/okta/stix_transmission/api_client.py 100.00% <100.00%> (ø)
...r_modules/okta/test/stix_transmission/test_okta.py 100.00% <100.00%> (+3.07%) ⬆️

... and 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@delliott90 delliott90 requested a review from baulus March 10, 2023 12:58
@baulus baulus self-requested a review March 10, 2023 14:34
1.Updated code changes for 429 request code by handling using  ErrorResponder.
2.Updated test cases for the same.
Updated status code for timeout error in connector.py, error mapper.py.
@mdazam1942 mdazam1942 merged commit e6b1c61 into opencybersecurityalliance:develop Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants