-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support large query with elastic search_after pagination #1299
support large query with elastic search_after pagination #1299
Conversation
… to upper applications(e.g., Kestrel)
Reimplement ElasticSearch pagination by moving while loop from stix-shifter to Kestrel in 1e89e28 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tingdai can you please fix the unittests?
@mdazam1942 I fixed testcase issues with the following commits: fe5ed4c and 2573ef6 |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #1299 +/- ##
===========================================
- Coverage 85.44% 85.42% -0.02%
===========================================
Files 569 569
Lines 42634 42693 +59
===========================================
+ Hits 36427 36471 +44
- Misses 6207 6222 +15
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
…nt as lastsort value.
stix_shifter_modules/elastic_ecs/stix_transmission/connector.py
Outdated
Show resolved
Hide resolved
There is one failing unit test because the |
stix_shifter_modules/elastic_ecs/stix_transmission/connector.py
Outdated
Show resolved
Hide resolved
@delliott90 Fixed in the new commit d0571da |
Use pagination to support large queries when the size is >10 k (default
max_result_window
in ElasticSearch).This is related to #1285