Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support large query with elastic search_after pagination #1299

Merged
merged 20 commits into from
Mar 1, 2023

Conversation

tingdai
Copy link
Collaborator

@tingdai tingdai commented Jan 27, 2023

Use pagination to support large queries when the size is >10 k (default max_result_window in ElasticSearch).
This is related to #1285

@CLAassistant
Copy link

CLAassistant commented Jan 27, 2023

CLA assistant check
All committers have signed the CLA.

@tingdai
Copy link
Collaborator Author

tingdai commented Jan 30, 2023

Reimplement ElasticSearch pagination by moving while loop from stix-shifter to Kestrel in 1e89e28

Copy link
Member

@mdazam1942 mdazam1942 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tingdai can you please fix the unittests?

@tingdai
Copy link
Collaborator Author

tingdai commented Feb 9, 2023

@tingdai can you please fix the unittests?

@mdazam1942 I fixed testcase issues with the following commits: fe5ed4c and 2573ef6

@codecov
Copy link

codecov bot commented Feb 9, 2023

Codecov Report

Patch coverage: 58.13% and project coverage change: -0.02 ⚠️

Comparison is base (71739d4) 85.44% compared to head (0a8d238) 85.42%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1299      +/-   ##
===========================================
- Coverage    85.44%   85.42%   -0.02%     
===========================================
  Files          569      569              
  Lines        42634    42693      +59     
===========================================
+ Hits         36427    36471      +44     
- Misses        6207     6222      +15     
Impacted Files Coverage Δ
...odules/elastic_ecs/stix_transmission/api_client.py 23.72% <16.00%> (+4.08%) ⬆️
...modules/elastic_ecs/stix_transmission/connector.py 73.73% <68.08%> (-5.90%) ⬇️
...ic_ecs/tests/stix_transmission/test_elastic_ecs.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@delliott90
Copy link
Collaborator

There is one failing unit test because the run_search() function was removed.

@tingdai
Copy link
Collaborator Author

tingdai commented Mar 1, 2023

There is one failing unit test because the run_search() function was removed.

@delliott90 Fixed in the new commit d0571da

@mdazam1942 mdazam1942 merged commit 8a82d3f into opencybersecurityalliance:develop Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants