Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS Athena, added external id support #1187

Merged
merged 3 commits into from
Nov 15, 2022

Conversation

baulus
Copy link
Contributor

@baulus baulus commented Nov 14, 2022

No description provided.

@codecov
Copy link

codecov bot commented Nov 14, 2022

Codecov Report

Base: 84.63% // Head: 84.63% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (291fd29) compared to base (119dd79).
Patch coverage: 75.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1187      +/-   ##
===========================================
- Coverage    84.63%   84.63%   -0.01%     
===========================================
  Files          557      557              
  Lines        41360    41363       +3     
===========================================
+ Hits         35006    35008       +2     
- Misses        6354     6355       +1     
Impacted Files Coverage Δ
...dules/aws_athena/stix_transmission/boto3_client.py 80.64% <75.00%> (-1.50%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mdazam1942 mdazam1942 marked this pull request as ready for review November 15, 2022 14:14
@mdazam1942 mdazam1942 merged commit c780d96 into develop Nov 15, 2022
@mdazam1942 mdazam1942 deleted the aws_athena_assume_role_external_id branch November 15, 2022 19:22
baulus pushed a commit that referenced this pull request Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants