Connector template for the demo #1117
Conversation
| { | ||
| "connection": { | ||
| "type": { | ||
| "displayName": "Async Sample" |
There was a problem hiding this comment.
Maybe rename to Demo Sample
| "host": { | ||
| "label": "Management IP address or Hostname", | ||
| "placeholder": "192.168.1.10", | ||
| "description": "Specify the IP address or hostname of the data source so that IBM Cloud Pak for Security can communicate with it" |
There was a problem hiding this comment.
Remove reference to CP4S
Codecov ReportBase: 64.78% // Head: 64.57% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #1117 +/- ##
===========================================
- Coverage 64.78% 64.57% -0.22%
===========================================
Files 531 541 +10
Lines 50601 50912 +311
===========================================
+ Hits 32784 32877 +93
- Misses 17817 18035 +218
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
| { | ||
| "ipv4-addr": { | ||
| "fields": { | ||
| "value": ["SourceIpV4-dialect1", "DestinationIpV4-dialect1"] |
There was a problem hiding this comment.
remove instances of dialect1 since the demo template will only have the default.
| @@ -0,0 +1,26 @@ | |||
| from stix_shifter_utils.modules.base.stix_transmission.base_ping_connector import BasePingConnector | |||
There was a problem hiding this comment.
can we move all *_connector.py method into one connector.py file to keep it as simple as possible?
No description provided.