Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding GCP Chronicle UDI Connector #1075

Merged

Conversation

lakshmi51974368
Copy link
Contributor

Adding GCP Chronicle UDI Connector

Adding GCP Chronicle UDI Connector
Updated requirements.txt
Updated requirements.txt
@codecov
Copy link

codecov bot commented Aug 11, 2022

Codecov Report

Base: 64.57% // Head: 64.26% // Decreases project coverage by -0.31% ⚠️

Coverage data is based on head (f6545b4) compared to base (9a6037e).
Patch coverage: 92.84% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1075      +/-   ##
===========================================
- Coverage    64.57%   64.26%   -0.32%     
===========================================
  Files          541      556      +15     
  Lines        50910    54246    +3336     
===========================================
+ Hits         32877    34862    +1985     
- Misses       18033    19384    +1351     
Impacted Files Coverage Δ
...dules/secretserver/stix_transmission/api_client.py 9.12% <0.00%> (-0.60%) ⬇️
...cp_chronicle/stix_transmission/status_connector.py 50.74% <81.92%> (ø)
...p_chronicle/stix_transmission/results_connector.py 52.91% <82.60%> (ø)
...gcp_chronicle/stix_transmission/query_connector.py 83.72% <83.72%> (ø)
...les/gcp_chronicle/stix_translation/transformers.py 78.04% <86.48%> (ø)
...cp_chronicle/stix_transmission/delete_connector.py 93.33% <93.33%> (ø)
...ules/gcp_chronicle/stix_transmission/api_client.py 67.36% <94.17%> (ø)
.../gcp_chronicle/stix_transmission/ping_connector.py 95.55% <95.55%> (ø)
...cp_chronicle/stix_translation/query_constructor.py 78.43% <95.94%> (ø)
...icle/tests/stix_transmission/test_gcp_chronicle.py 60.55% <97.68%> (ø)
... and 8 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Updated test_gcp_chronicle_stix_to_query.py
Updated code to set the default protocol value when protocol information is not present. Avoided deletion of network event.
lakshmi51974368 and others added 2 commits September 8, 2022 14:24
1. Updated the description of Self Signed Cert
2. Handled invalid private key with proper error handling.
3. Updated code to handle the qualifier without milliseconds.
The sleep for resource exhaustion has been removed in api_client.py and added debug for deletion operation in results_connector.py
1. Removed the logic to validate the AWS Guardduty events in results_connector.py.
2. Removed the corresponding unit test case handled for Guardduty event.
@mdazam1942 mdazam1942 merged commit 41eadfb into opencybersecurityalliance:develop Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants