-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding GCP Chronicle UDI Connector #1075
Adding GCP Chronicle UDI Connector #1075
Conversation
Adding GCP Chronicle UDI Connector
Updated requirements.txt
Updated requirements.txt
Codecov ReportBase: 64.57% // Head: 64.26% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #1075 +/- ##
===========================================
- Coverage 64.57% 64.26% -0.32%
===========================================
Files 541 556 +15
Lines 50910 54246 +3336
===========================================
+ Hits 32877 34862 +1985
- Misses 18033 19384 +1351
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Updated test_gcp_chronicle_stix_to_query.py
Updated code to set the default protocol value when protocol information is not present. Avoided deletion of network event.
stix_shifter_modules/gcp_chronicle/stix_translation/query_constructor.py
Outdated
Show resolved
Hide resolved
Updated lang_en.json and query_constructor.py to address the review comments.
stix_shifter_modules/gcp_chronicle/stix_translation/transformers.py
Outdated
Show resolved
Hide resolved
stix_shifter_modules/gcp_chronicle/stix_translation/query_constructor.py
Show resolved
Hide resolved
1. Updated the description of Self Signed Cert 2. Handled invalid private key with proper error handling. 3. Updated code to handle the qualifier without milliseconds.
stix_shifter_modules/gcp_chronicle/stix_transmission/results_connector.py
Outdated
Show resolved
Hide resolved
stix_shifter_modules/gcp_chronicle/stix_transmission/results_connector.py
Outdated
Show resolved
Hide resolved
stix_shifter_modules/gcp_chronicle/stix_transmission/results_connector.py
Outdated
Show resolved
Hide resolved
stix_shifter_modules/gcp_chronicle/stix_transmission/results_connector.py
Outdated
Show resolved
Hide resolved
Updated code with review comments in results_connector and api_client files.
…/stix-shifter into gcp_chronicle_v1
stix_shifter_modules/gcp_chronicle/stix_transmission/api_client.py
Outdated
Show resolved
Hide resolved
stix_shifter_modules/gcp_chronicle/stix_transmission/results_connector.py
Show resolved
Hide resolved
The sleep for resource exhaustion has been removed in api_client.py and added debug for deletion operation in results_connector.py
stix_shifter_modules/gcp_chronicle/stix_transmission/results_connector.py
Outdated
Show resolved
Hide resolved
stix_shifter_modules/gcp_chronicle/stix_transmission/results_connector.py
Outdated
Show resolved
Hide resolved
stix_shifter_modules/gcp_chronicle/stix_translation/json/to_stix_map.json
Show resolved
Hide resolved
1. Removed the logic to validate the AWS Guardduty events in results_connector.py. 2. Removed the corresponding unit test case handled for Guardduty event.
Adding GCP Chronicle UDI Connector