(5.x) Merge 4.x #3769
Merged
(5.x) Merge 4.x #3769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed a clerical error in qrcode.py
also link to CUDA::cufft_static in case of BUILD_SHARED_LIBS=OFF
…ngle supports empty kernels in cuda::SeparableLinearFilters opencv#3731 [#25408](opencv/opencv#25408) When only 1D convolution is needed (row or column filter only), `cuda::LinearFilter` might be slower than `cuda::SeparableLinearFilter` Using `cuda::SeparableLinearFilter` for 1D convolution can be done by using a `(1)` kernel for the ignored dimension. By supporting empty kernels in `cuda::SeparableLinearFilter`, there is no need for that `(1)` kernel any more. Additionaly, the inner `_buf ` used to store the intermediate convolution result can be saved when a single convolution is needed. In "legacy" usage (row+col kernels), there is no regression in `cuda::SeparableLinearFilter` performance. As soon as an empty kernel is used, the performance is largely increased. Devil in the details : the "in-place" processing is supported and might need intermediate buf, but still no regression. - [X] I agree to contribute to the project under Apache 2 License. - [X] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV - [X] The PR is proposed to the proper branch - [X] There is a reference to the original bug report and related work - [X] There is accuracy test, performance test and test data in opencv_extra repository, if applicable Patch to opencv_extra has the same branch name. - [X] The feature is well documented and sample code can be built with the project CMake
This was referenced Jul 16, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenCV: opencv/opencv#25915
OpenCV Extra: opencv/opencv_extra#1193
#3731 from chacha21:cuda_separable_filter_single
#3748 from wangqiang9:patch-1
#3753 from gregorburger:4.x
Previous "Merge 4.x": #3763