Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EDColor related algorithms to EdgeDrawing Class #3764

Open
wants to merge 1 commit into
base: 4.x
Choose a base branch
from

Conversation

sturkmen72
Copy link
Contributor

related #2314

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@sturkmen72
Copy link
Contributor Author

@asmorkalov could you start the tests please.

@asmorkalov
Copy link
Contributor

asmorkalov commented Sep 19, 2024

@sturkmen72 I see regular commits to the PR. I switched it to WIP. Please return it back, when it's ready.

@asmorkalov asmorkalov changed the title Add EDColor related algorithms to EdgeDrawing Class WIP: Add EDColor related algorithms to EdgeDrawing Class Sep 19, 2024
Fixed a bug where params.PFmode = true caused incorrect edge detection results.
Updated edge_drawing.py to support the new EDColor feature.
Created a new edge_drawing_demo.cpp for demonstrating the EDColor feature.
Updated ximgproc.bib to include references for EDColor.
Added tests for PFmode and EDColor in test_fld.cpp.
Added CV_WRAP to Params::read and Params::write functions to expose them to Python bindings.
the class NFALUT uses the code from original ED code
@sturkmen72 sturkmen72 changed the title WIP: Add EDColor related algorithms to EdgeDrawing Class Add EDColor related algorithms to EdgeDrawing Class Sep 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants