Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cudacodec::VideoReader: force output frame resolution to be display not coded size #3470

Merged
merged 1 commit into from
Apr 17, 2023

Conversation

cudawarped
Copy link
Contributor

@cudawarped cudawarped commented Apr 12, 2023

Now that cropping can automatically be applied inside cudacodec::VideoReader (#3355) in addition to the fixes in #3001 this PR automatically removes any redundant rows in decoded video's. E.g 1080p is internally decoded to 1920x1088, currently this results in a 1920x1088 frame being returned from VideoReader->nextFrame() which the user has to manually crop using the information contained in VideoReader::FormatInfo, with this PR it will result in a 1920x1080 frame being returned.

This resolves issues such as #3195 and opencv/opencv#21207 (comment)

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

Copy link
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Tested manually with CUDA 10.2, Ubuntu 18.04.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants