Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flipped image in documentation #3469

Merged
merged 1 commit into from
Apr 11, 2023
Merged

Fix flipped image in documentation #3469

merged 1 commit into from
Apr 11, 2023

Conversation

smeng9
Copy link
Contributor

@smeng9 smeng9 commented Apr 11, 2023

Move the PR to opencv_contrib. See opencv/opencv#23432 (review)

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@AleksandrPanov AleksandrPanov added category: aruco category: documentation Documentation fix or update, does not affect code labels Apr 11, 2023
@AleksandrPanov AleksandrPanov self-requested a review April 11, 2023 07:46
AleksandrPanov
AleksandrPanov approved these changes Apr 11, 2023
View reviewed changes
Copy link
Contributor

@AleksandrPanov AleksandrPanov left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was an error in the documentation. PR fixes it.

The PatternPositionType in the documentation
https://docs.opencv.org/4.7.0/d9/d6a/group__aruco.html#ga27275294ed214f3872ddef00d86d40d5

@asmorkalov asmorkalov merged commit fd411e7 into opencv:4.x Apr 11, 2023
@asmorkalov asmorkalov mentioned this pull request May 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AleksandrPanov AleksandrPanov AleksandrPanov approved these changes

Assignees

@AleksandrPanov AleksandrPanov

Labels
category: aruco category: documentation Documentation fix or update, does not affect code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smeng9 @AleksandrPanov @asmorkalov