Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set window_size to 1 if round down results in 0 for barcodes #3331

Merged
merged 1 commit into from
Sep 5, 2022

Conversation

kishorgandham
Copy link
Contributor

@kishorgandham kishorgandham commented Aug 21, 2022

Without this fix, we will get a floating point error in calCoherence method due to divide by zero.

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

… will get a floating point error in calCoherence method due to divide by zeor
@asmorkalov asmorkalov changed the title Set window_size to 1 if round down results in 0. Without this fix, we… Set window_size to 1 if round down results in 0 for barcodes Sep 5, 2022
@asmorkalov asmorkalov self-requested a review September 5, 2022 07:46
@asmorkalov asmorkalov self-assigned this Sep 5, 2022
@asmorkalov asmorkalov merged commit 4a91f2f into opencv:4.x Sep 5, 2022
@alalek alalek mentioned this pull request Jan 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants