-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
proposals/distribution: remove non-sense about image indexes #49
proposals/distribution: remove non-sense about image indexes #49
Conversation
Signed-off-by: Stephen J Day <stephen.day@docker.com>
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments..
Managing groups of image indexes requires multi-[image-index][] actions, which are out of scope for this entry. | ||
Listing image indexes within a group is a multi-[image-index][] action, which is out of scope for this entry. | ||
* Description: Define a protocol for creating, retrieving, updating, and deleting content-addressable objects, such as those defined in the [image specification][image-spec]. | ||
Listing repositories is a registry-wide operation; the implementation of which is out of scope of this document. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: this is a first introduction of term "document." Suggest using this "spec."
Also this listing restriction does not make sense here. Can we move it to the Grouping line above on 109 and change the word grouping to a broader term like "managing?" "Managing the grouping of images (image names) as repositories within a registry is considered part of distribution policy or content management, which are out of scope for this spec."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The relationship between these two sentences is not straightforward. However I do think this is referring to slightly different functionality. While the "grouping" section is just saying that each repository name is considered independent from the perspective of the API, this is referring to an endpoint which lists all the repository names within a registry. While the group and name hierarchy could be of interest to an end API user, cataloging has normally just be considered an administrative endpoint not exposed to API users.
+1 on document -> specification
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool..
Maybe.. "An endpoint for listing repository names within a registry, is considered out of scope for this spec and thus also out of scope for this protocol." Or distribution protocol...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That language sounds clearer, let me update and move it next to tag listing. I don't think these statements belong here.
Pulled this commit into #50, please close this PR |
closing per request with changes in #50 |
Signed-off-by: Stephen J Day stephen.day@docker.com