-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Go 1.22 and 1.23, rm old versions, bump CI actions, bump golangci-linter #776
base: master
Are you sure you want to change the base?
Conversation
@opencontainers/runtime-tools-maintainers PTAL |
.github/workflows/test.yml
Outdated
@@ -44,14 +44,14 @@ jobs: | |||
strategy: | |||
fail-fast: false | |||
matrix: | |||
go-version: [1.19.x, 1.20.x] | |||
go-version: [1.22.x, 1.23.x] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should still include 1.19 here for go.mod, right? Or do something clever with the go-version-file:
support in setup-go?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure it makes sense to test on older Go releases, unless we explicitly want to maintain compatibility with older Go versions (and for now I don't know a reason to do that).
go version in go.mod
will raise naturally once we'll start using newer features.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides, we're switching to go 1.21 as a minimum in #777
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be ok to use;
min
version (go1.19 or go1.21 after Switch to github.com/moby/sys/capability #777)latest
latest - 1
The last 2 being the currently supported versions, and the min
version to verify that the minimum version specified in go.mod
isn't lying.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated; PTAL @thaJeztah
@opencontainers/runtime-tools-maintainers PTAL 🙏🏻 |
Found by golangci-lint v1.60.1: cmd/oci-runtime-tool/main.go:59:17: printf: non-constant format string in call to github.com/sirupsen/logrus.Fatalf (govet) logrus.Fatalf(err.Error()) ^ Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Go 1.23 is released, making Go 1.21 (and older version) unsupported. Yet, let's also keep the version from go.mod. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Oh, interesting; I have a green check here, but I'm not in the maintainers list for this repo. Wondering if some permissions were set too relaxed? |
It looks like members of both runtime-tools-maintainers and runtime-spec-maintainers are admins here. |
@tianon we need a "still lgtm" from you here 🧔🏻 |
Mostly a CI refresh. See commits for details.
Closes: #769