-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] update initruntimetest by linzhinan #61
Conversation
Signed-off-by: linzhinan(zen Lin) <linzhinan@huawei.com>
any suggestions on state test and lifecirle test? @zenlinTechnofreak |
"strings" | ||
|
||
"github.com/Sirupsen/logrus" | ||
"github.com/opencontainers/ocitools/config" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Travis doesn't like this import, and you don't seem to use config.…
in unit.go
anyway, so you can probably drop this line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, you dropped the config package in cb986be and just forgot this line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for correction, I'll change that add post a working version.
There was some consensus in #47 about making runtime testing a |
Signed-off-by: linzhinan(zen lin) <linzhinan@huawei.com>
d59e6a4
to
9c08ae3
Compare
Signed-off-by: liang chenye <liangchenye@huawei.com>
6930018
to
ad60254
Compare
The purpose of using golang in runtime test (or runtime certification) is we need to test more cases. |
On Tue, May 10, 2016 at 07:16:54AM -0700, 梁辰晔 (Liang Chenye) wrote:
I'm not recommending a single command-line script, I'm recommending |
Signed-off-by: liang chenye <liangchenye@huawei.com>
ad60254
to
712c420
Compare
Signed-off-by: liang chenye <liangchenye@huawei.com>
64bc2e1
to
3c7a49e
Compare
Signed-off-by: liang chenye <liangchenye@huawei.com>
It seems like the resistance to using bats, sharness, Python (#98), I'm not excited about writing and maintaining our own Go test harness, |
any updates? |
Close and split it into small issues/PRs. |
This pr is still under development.
Since we have 'state' and 'lifecircle' defined now (comparing to zhinan's previous PR #9)
This PR not only test the main configs (verified by cmd/runtimetest), but also test the state and life circle.