use go > 1.5 since golint drop support for 1.5 #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: liang chenye <liangchenye@huawei.com>
|
I think I'm okay with this. @crosbymichael is there currently an expectation for golang version with runc, et al? |
|
@vbatts We are building runc with 1.7.1 so this is fine. |
|
LGTM |
wking
pushed a commit
to wking/ocitools-v2
that referenced
this pull request
Oct 13, 2016
Signed-off-by: liang chenye <liangchenye@huawei.com> Backported to v1.0.0.rc1 from f9096d8 opencontainers#230 (cherry-pick applied cleanly). Signed-off-by: W. Trevor King <wking@tremily.us>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
go 1.5.3 fails to run golint in 'travis' file.
Find the reason for this:
golang/lint@a428635
Signed-off-by: liang chenye liangchenye@huawei.com